Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1804)

Unified Diff: sky/engine/core/rendering/RenderImage.cpp

Issue 856563006: Remove background obscuration checks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderImage.h ('k') | sky/engine/core/rendering/RenderLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderImage.cpp
diff --git a/sky/engine/core/rendering/RenderImage.cpp b/sky/engine/core/rendering/RenderImage.cpp
index f04aabd61fbff7148555f8b8d7036b8ad4eb6bec..2f3a8530f3bf84164606d94ef02016063a1eac0d 100644
--- a/sky/engine/core/rendering/RenderImage.cpp
+++ b/sky/engine/core/rendering/RenderImage.cpp
@@ -162,17 +162,6 @@ void RenderImage::updateInnerContentRect()
m_imageResource->setContainerSizeForRenderer(containerSize);
}
-void RenderImage::notifyFinished(Resource* newImage)
-{
- if (!m_imageResource)
- return;
-
- if (documentBeingDestroyed())
- return;
-
- invalidateBackgroundObscurationStatus();
-}
-
void RenderImage::paintReplaced(PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
GraphicsContext* context = paintInfo.context;
@@ -227,51 +216,6 @@ void RenderImage::paintIntoRect(GraphicsContext* context, const LayoutRect& rect
context->setImageInterpolationQuality(previousInterpolationQuality);
}
-bool RenderImage::boxShadowShouldBeAppliedToBackground(BackgroundBleedAvoidance bleedAvoidance, InlineFlowBox*) const
-{
- if (!RenderBoxModelObject::boxShadowShouldBeAppliedToBackground(bleedAvoidance))
- return false;
-
- return !const_cast<RenderImage*>(this)->boxDecorationBackgroundIsKnownToBeObscured();
-}
-
-bool RenderImage::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned) const
-{
- if (!m_imageResource->hasImage() || m_imageResource->errorOccurred())
- return false;
- if (m_imageResource->cachedImage() && !m_imageResource->cachedImage()->isLoaded())
- return false;
- if (!contentBoxRect().contains(localRect))
- return false;
- EFillBox backgroundClip = style()->backgroundClip();
- // Background paints under borders.
- if (backgroundClip == BorderFillBox && style()->hasBorder() && !borderObscuresBackground())
- return false;
- // Background shows in padding area.
- if ((backgroundClip == BorderFillBox || backgroundClip == PaddingFillBox) && style()->hasPadding())
- return false;
- // Object-position may leave parts of the content box empty, regardless of the value of object-fit.
- if (style()->objectPosition() != RenderStyle::initialObjectPosition())
- return false;
- // Object-fit may leave parts of the content box empty.
- ObjectFit objectFit = style()->objectFit();
- if (objectFit != ObjectFitFill && objectFit != ObjectFitCover)
- return false;
- // Check for image with alpha.
- return m_imageResource->cachedImage() && m_imageResource->cachedImage()->currentFrameKnownToBeOpaque(this);
-}
-
-bool RenderImage::computeBackgroundIsKnownToBeObscured()
-{
- if (!hasBackground())
- return false;
-
- LayoutRect paintedExtent;
- if (!getBackgroundPaintedExtent(paintedExtent))
- return false;
- return foregroundIsKnownToBeOpaqueInRect(paintedExtent, 0);
-}
-
LayoutUnit RenderImage::minimumReplacedHeight() const
{
return m_imageResource->errorOccurred() ? intrinsicSize().height() : LayoutUnit();
« no previous file with comments | « sky/engine/core/rendering/RenderImage.h ('k') | sky/engine/core/rendering/RenderLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698