Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 853883004: Revert of Sketch DM refactor. (Closed)

Created:
5 years, 11 months ago by mtklein
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Sketch DM refactor. (patchset #45 id:850001 of https://codereview.chromium.org/788243008/) Reason for revert: plenty of data Original issue's description: > Sketch DM refactor. > > BUG=skia:3255 > > > I think this supports everything DM used to, but has completely refactored how > it works to fit the design in the bug. > > Configs like "tiles-gpu" are automatically wired up. > > I wouldn't suggest looking at this as a diff. There's just a bunch of deleted > files, a few new files, and one new file that shares a name with a deleted file > (DM.cpp). > > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/709d2c3e5062c5b57f91273bfc11a751f5b2bb88 TBR=bsalomon@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3255 Committed: https://skia.googlesource.com/skia/+/114c3cd0543d77aa0ac08d8af436ac7f9d32714d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2080 lines, -987 lines) Patch
M bench/nanobench.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M dm/DM.cpp View 2 chunks +266 lines, -396 lines 0 comments Download
A dm/DMCpuGMTask.h View 1 chunk +38 lines, -0 lines 0 comments Download
A dm/DMCpuGMTask.cpp View 1 chunk +56 lines, -0 lines 0 comments Download
A dm/DMGpuGMTask.h View 1 chunk +43 lines, -0 lines 0 comments Download
A dm/DMGpuGMTask.cpp View 1 chunk +67 lines, -0 lines 0 comments Download
A dm/DMImageTask.h View 1 chunk +30 lines, -0 lines 0 comments Download
A dm/DMImageTask.cpp View 1 chunk +78 lines, -0 lines 0 comments Download
M dm/DMJsonWriter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M dm/DMJsonWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
A dm/DMPDFRasterizeTask.h View 1 chunk +41 lines, -0 lines 0 comments Download
A dm/DMPDFRasterizeTask.cpp View 1 chunk +38 lines, -0 lines 0 comments Download
A dm/DMPDFTask.h View 1 chunk +47 lines, -0 lines 0 comments Download
A dm/DMPDFTask.cpp View 1 chunk +106 lines, -0 lines 0 comments Download
A dm/DMPipeTask.h View 1 chunk +41 lines, -0 lines 0 comments Download
A dm/DMPipeTask.cpp View 1 chunk +83 lines, -0 lines 0 comments Download
A dm/DMQuiltTask.h View 1 chunk +39 lines, -0 lines 0 comments Download
A dm/DMQuiltTask.cpp View 1 chunk +98 lines, -0 lines 0 comments Download
A dm/DMReporter.h View 1 chunk +36 lines, -0 lines 0 comments Download
A dm/DMReporter.cpp View 1 chunk +46 lines, -0 lines 0 comments Download
A dm/DMSKPTask.h View 1 chunk +30 lines, -0 lines 0 comments Download
A dm/DMSKPTask.cpp View 1 chunk +31 lines, -0 lines 0 comments Download
A dm/DMSerializeTask.h View 1 chunk +31 lines, -0 lines 0 comments Download
A dm/DMSerializeTask.cpp View 1 chunk +44 lines, -0 lines 0 comments Download
D dm/DMSrcSink.h View 1 chunk +0 lines, -177 lines 0 comments Download
D dm/DMSrcSink.cpp View 1 chunk +0 lines, -389 lines 0 comments Download
A dm/DMTask.h View 1 chunk +74 lines, -0 lines 0 comments Download
A dm/DMTask.cpp View 1 chunk +91 lines, -0 lines 0 comments Download
A dm/DMTaskRunner.h View 1 chunk +29 lines, -0 lines 0 comments Download
A dm/DMTaskRunner.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
A dm/DMTestTask.h View 1 chunk +66 lines, -0 lines 0 comments Download
A dm/DMTestTask.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
A dm/DMUtil.h View 1 chunk +43 lines, -0 lines 0 comments Download
A dm/DMUtil.cpp View 1 chunk +118 lines, -0 lines 0 comments Download
A dm/DMWriteTask.h View 1 chunk +45 lines, -0 lines 0 comments Download
A dm/DMWriteTask.cpp View 1 chunk +189 lines, -0 lines 0 comments Download
A dm/README View 1 chunk +27 lines, -0 lines 0 comments Download
M gyp/dm.gypi View 2 chunks +15 lines, -2 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/timer/Timer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/timer/Timer.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Sketch DM refactor.
5 years, 11 months ago (2015-01-15 18:14:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853883004/1
5 years, 11 months ago (2015-01-15 18:14:34 UTC) #2
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 18:15:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/114c3cd0543d77aa0ac08d8af436ac7f9d32714d

Powered by Google App Engine
This is Rietveld 408576698