Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 846303002: Make uncached textures uncached from the get go. (Closed)

Created:
5 years, 11 months ago by bsalomon
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make uncached textures uncached from the get go. This avoids the problem of a newly created uncached texture causing a purge of cached resources. BUG=chromium:445885 Committed: https://skia.googlesource.com/skia/+/5236cf480daf82b2f36e42795abdbbc915533a59

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : fix nanobench #

Patch Set 4 : sknew #

Patch Set 5 : minor #

Patch Set 6 : minor #

Patch Set 7 : fix #

Total comments: 4

Patch Set 8 : address comments #

Patch Set 9 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -198 lines) Patch
M bench/GrResourceCacheBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrGpuResource.h View 1 2 3 4 5 6 7 8 6 chunks +24 lines, -16 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 1 chunk +2 lines, -4 lines 0 comments Download
M include/gpu/GrSurface.h View 1 chunk +3 lines, -3 lines 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 5 6 5 chunks +6 lines, -13 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGeometryBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 2 chunks +3 lines, -25 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 2 chunks +2 lines, -11 lines 0 comments Download
M src/gpu/GrIndexBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPath.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrPathRange.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrPathRange.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrStencilBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrVertexBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 14 chunks +17 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLIndexBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLStencilBuffer.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLTextureRenderTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLVertexBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 4 5 6 7 15 chunks +117 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
fixes a beta blocker
5 years, 11 months ago (2015-01-13 21:39:34 UTC) #2
robertphillips
lgtm & a question & a suggestion https://codereview.chromium.org/846303002/diff/110001/include/gpu/GrGpuResource.h File include/gpu/GrGpuResource.h (right): https://codereview.chromium.org/846303002/diff/110001/include/gpu/GrGpuResource.h#newcode134 include/gpu/GrGpuResource.h:134: kCached_LifeCycle, Don't ...
5 years, 11 months ago (2015-01-14 16:42:59 UTC) #3
bsalomon
https://codereview.chromium.org/846303002/diff/110001/include/gpu/GrGpuResource.h File include/gpu/GrGpuResource.h (right): https://codereview.chromium.org/846303002/diff/110001/include/gpu/GrGpuResource.h#newcode134 include/gpu/GrGpuResource.h:134: kCached_LifeCycle, On 2015/01/14 16:42:59, robertphillips wrote: > Don't we ...
5 years, 11 months ago (2015-01-14 18:32:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/846303002/150001
5 years, 11 months ago (2015-01-14 18:32:38 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:42:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #9 (id:150001) as
https://skia.googlesource.com/skia/+/5236cf480daf82b2f36e42795abdbbc915533a59

Powered by Google App Engine
This is Rietveld 408576698