Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 845313004: Service Worker: Improve error messages from register(). (Closed)

Created:
5 years, 11 months ago by falken
Modified:
5 years, 11 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Service Worker: Improve error messages from register(). This augments the result from RegisterJob with an optional string explaning the status. Previously we could only convey rather generic errors. Sample improvements: Before: "Operation failed by network issue" After: "A bad HTTP response code (404) was received when fetching the script." Before: "Operation failed by security issue" After: "The script has an unsupported MIME type ('text/plain')." BUG=436928 TBR=mek@ for trivial change to geofencing unittest Committed: https://crrev.com/3008af5bdb59ef3faca7444f3a121026662667ac Cr-Commit-Position: refs/heads/master@{#312114}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : sync #

Patch Set 4 : git-cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -63 lines) Patch
M content/browser/geofencing/geofencing_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 3 chunks +7 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 13 chunks +26 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_status.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_status.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_script_cache_map.h View 3 chunks +7 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_script_cache_map.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 1 2 3 16 chunks +67 lines, -30 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
falken
PTAL. Tested locally with https://codereview.chromium.org/849403002 but I'm not sure I want to commit that. At ...
5 years, 11 months ago (2015-01-16 06:59:32 UTC) #2
nhiroki
LGTM (comments are optional) https://codereview.chromium.org/845313004/diff/1/content/browser/service_worker/service_worker_write_to_cache_job.cc File content/browser/service_worker/service_worker_write_to_cache_job.cc (right): https://codereview.chromium.org/845313004/diff/1/content/browser/service_worker/service_worker_write_to_cache_job.cc#newcode374 content/browser/service_worker/service_worker_write_to_cache_job.cc:374: kBadResponseCodeError); Appending the bad response ...
5 years, 11 months ago (2015-01-19 02:18:17 UTC) #3
falken
Thanks, want to take a look again?
5 years, 11 months ago (2015-01-19 09:49:25 UTC) #4
nhiroki
lgtm
5 years, 11 months ago (2015-01-19 10:17:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/845313004/60001
5 years, 11 months ago (2015-01-19 14:20:56 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-19 15:18:02 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 15:19:26 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3008af5bdb59ef3faca7444f3a121026662667ac
Cr-Commit-Position: refs/heads/master@{#312114}

Powered by Google App Engine
This is Rietveld 408576698