content/browser/service_worker/service_worker_context_core.h - Issue 845313004: Service Worker: Improve error messages from register().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.h

Issue 845313004: Service Worker: Improve error messages from register(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git-cl format Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geofencing/geofencing_manager_unittest.cc ('k') | content/browser/service_worker/service_worker_context_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.h

diff --git a/content/browser/service_worker/service_worker_context_core.h b/content/browser/service_worker/service_worker_context_core.h

index 8c534b11d7e6e19b45f50d97afbd263d1ba0bf7f..615954a807ea06b3a1c671c4995b59b83e33f7c6 100644

--- a/content/browser/service_worker/service_worker_context_core.h

+++ b/content/browser/service_worker/service_worker_context_core.h

@@ -61,6 +61,7 @@ class CONTENT_EXPORT ServiceWorkerContextCore

public:

typedef base::Callback<void(ServiceWorkerStatusCode status)> StatusCallback;

typedef base::Callback<void(ServiceWorkerStatusCode status,

+ const std::string& status_message,

int64 registration_id)> RegistrationCallback;

typedef base::Callback<

void(ServiceWorkerStatusCode status)> UnregistrationCallback;

@@ -213,6 +214,7 @@ class CONTENT_EXPORT ServiceWorkerContextCore

void RegistrationComplete(const GURL& pattern,

const RegistrationCallback& callback,

ServiceWorkerStatusCode status,

+ const std::string& status_message,

ServiceWorkerRegistration* registration);

void UnregistrationComplete(const GURL& pattern,