Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1296)

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 845313004: Service Worker: Improve error messages from register(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git-cl format Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc
index 73148d8b6948c82cbed0a18bc0aa5d55a64abe34..a9ecbfb18a77f9ce9ee0c8a65fb77bb144f9ce3c 100644
--- a/content/browser/service_worker/service_worker_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_job_unittest.cc
@@ -38,6 +38,7 @@ void SaveRegistrationCallback(
bool* called,
scoped_refptr<ServiceWorkerRegistration>* registration_out,
ServiceWorkerStatusCode status,
+ const std::string& status_message,
ServiceWorkerRegistration* registration) {
EXPECT_EQ(expected_status, status);
*called = true;
@@ -944,7 +945,7 @@ class UpdateJobTestHelper
version->script_cache_map()->NotifyStartedCaching(script, resource_id);
WriteStringResponse(storage(), resource_id, kMockScriptBody);
version->script_cache_map()->NotifyFinishedCaching(
- script, kMockScriptSize, net::URLRequestStatus());
+ script, kMockScriptSize, net::URLRequestStatus(), std::string());
} else {
// Spoof caching the script for the new version.
int64 resource_id = storage()->NewResourceId();
@@ -954,7 +955,7 @@ class UpdateJobTestHelper
else
WriteStringResponse(storage(), resource_id, "mock_different_script");
version->script_cache_map()->NotifyFinishedCaching(
- script, kMockScriptSize, net::URLRequestStatus());
+ script, kMockScriptSize, net::URLRequestStatus(), std::string());
}
EmbeddedWorkerTestHelper::OnStartWorker(
embedded_worker_id, version_id, scope, script, pause_after_download);

Powered by Google App Engine
This is Rietveld 408576698