Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: content/browser/service_worker/service_worker_script_cache_map.cc

Issue 845313004: Service Worker: Improve error messages from register(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git-cl format Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_script_cache_map.cc
diff --git a/content/browser/service_worker/service_worker_script_cache_map.cc b/content/browser/service_worker/service_worker_script_cache_map.cc
index a0f648b2738e641a14affd3058903ea706a791f1..6c74466e41c8198b6cae2910be076c7de737d425 100644
--- a/content/browser/service_worker/service_worker_script_cache_map.cc
+++ b/content/browser/service_worker/service_worker_script_cache_map.cc
@@ -51,7 +51,8 @@ void ServiceWorkerScriptCacheMap::NotifyStartedCaching(
void ServiceWorkerScriptCacheMap::NotifyFinishedCaching(
const GURL& url,
int64 size_bytes,
- const net::URLRequestStatus& status) {
+ const net::URLRequestStatus& status,
+ const std::string& status_message) {
DCHECK_NE(kInvalidServiceWorkerResponseId, LookupResourceId(url));
DCHECK(owner_->status() == ServiceWorkerVersion::NEW ||
owner_->status() == ServiceWorkerVersion::INSTALLING);
@@ -60,8 +61,10 @@ void ServiceWorkerScriptCacheMap::NotifyFinishedCaching(
if (!status.is_success()) {
context_->storage()->DoomUncommittedResponse(LookupResourceId(url));
resource_map_.erase(url);
- if (owner_->script_url() == url)
+ if (owner_->script_url() == url) {
main_script_status_ = status;
+ main_script_status_message_ = status_message;
+ }
} else {
resource_map_[url].size_bytes = size_bytes;
}

Powered by Google App Engine
This is Rietveld 408576698