Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 842113005: Delete a bunch of noop paint invalidation code. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete a bunch of noop paint invalidation code. This deletes invalidateRect and all it's callers. There are no logic changes, just deletes. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/77462799e05c5cc2a3472bd07b94a9b7a1b18f43

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -701 lines) Patch
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/Chrome.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/Chrome.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M sky/engine/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M sky/engine/platform/HostWindow.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/platform/Widget.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/graphics/Canvas2DLayerBridge.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/platform/graphics/ImageBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/graphics/ImageBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/ImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.h View 4 chunks +0 lines, -26 lines 0 comments Download
M sky/engine/platform/scroll/ScrollableArea.cpp View 3 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.h View 5 chunks +2 lines, -16 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 8 chunks +0 lines, -53 lines 0 comments Download
M sky/engine/public/platform/WebExternalTextureLayer.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/public/platform/WebLayer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/public/web/WebWidget.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/public/web/WebWidgetClient.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
D sky/engine/web/painting/PaintAggregator.h View 1 chunk +0 lines, -92 lines 0 comments Download
D sky/engine/web/painting/PaintAggregator.cpp View 1 chunk +0 lines, -373 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
5 years, 11 months ago (2015-01-17 01:39:40 UTC) #2
ojan
5 years, 11 months ago (2015-01-17 01:42:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
77462799e05c5cc2a3472bd07b94a9b7a1b18f43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698