Delete a bunch of noop paint invalidation code.

sky/engine/platform/scroll/Scrollbar.cpp

 /*
  * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 89 matching lines @@
 void Scrollbar::offsetDidChange()
 {
     ASSERT(m_scrollableArea);
 
     float position = scrollableAreaCurrentPos();
     if (position == m_currentPos)
         return;
 
     int oldThumbPosition = thumbPosition();
     m_currentPos = position;
-    updateThumb();
     if (m_pressedPart == ThumbPart)
         setPressedPos(m_pressedPos + thumbPosition() - oldThumbPosition);
 }
 
 void Scrollbar::setProportion(int visibleSize, int totalSize)
 {
     if (visibleSize == m_visibleSize && totalSize == m_totalSize)
         return;
 
     m_visibleSize = visibleSize;
     m_totalSize = totalSize;
-
-    updateThumb();
-}
-
-void Scrollbar::updateThumb()
-{
-#ifdef THUMB_POSITION_AFFECTS_BUTTONS
-    invalidate();
-#else
-    invalidateParts();
-#endif
 }
 
 void Scrollbar::paint(GraphicsContext* context, const IntRect& damageRect)
 {
     if (!frameRect().intersects(damageRect))
         return;
 
     IntRect startTrackRect;
     IntRect thumbRect;
     IntRect endTrackRect;
@@ skipping 15 matching lines @@
 }
 
 void Scrollbar::autoscrollPressedPart(double delay)
 {
     // Don't do anything for the thumb or if nothing was pressed.
     if (m_pressedPart == ThumbPart || m_pressedPart == NoPart)
         return;
 
     // Handle the track.
     if ((m_pressedPart == BackTrackPart || m_pressedPart == ForwardTrackPart) && thumbUnderMouse(this)) {
-        invalidatePart(m_pressedPart);
         setHoveredPart(ThumbPart);
         return;
     }
 
     // Handle the arrows and track.
     if (m_scrollableArea && m_scrollableArea->scroll(pressedPartScrollDirection(), pressedPartScrollGranularity()))
         startTimerIfNeeded(delay);
 }
 
 void Scrollbar::startTimerIfNeeded(double delay)
 {
     // Don't do anything for the thumb.
     if (m_pressedPart == ThumbPart)
         return;
 
     // Handle the track.  We halt track scrolling once the thumb is level
     // with us.
     if ((m_pressedPart == BackTrackPart || m_pressedPart == ForwardTrackPart) && thumbUnderMouse(this)) {
-        invalidatePart(m_pressedPart);
         setHoveredPart(ThumbPart);
         return;
     }
 
     // We can't scroll if we've hit the beginning or end.
     ScrollDirection dir = pressedPartScrollDirection();
     if (dir == ScrollUp || dir == ScrollLeft) {
         if (m_currentPos == 0)
             return;
     } else {
@@ skipping 50 matching lines @@
     if (delta) {
         float newPosition = static_cast<float>(thumbPos + delta) * (maxPos - minPos) / (trackLen - thumbLen) + minPos;
         m_scrollableArea->scrollToOffsetWithoutAnimation(m_orientation, newPosition);
     }
 }
 
 void Scrollbar::setHoveredPart(ScrollbarPart part)
 {
     if (part == m_hoveredPart)
         return;
-
-    if (m_pressedPart == NoPart) {  // When there's a pressed part, we don't draw a hovered state, so there's no reason to invalidate.
-        invalidatePart(part);
-        invalidatePart(m_hoveredPart);
-    }
     m_hoveredPart = part;
 }
 
 void Scrollbar::setPressedPart(ScrollbarPart part)
 {
-    if (m_pressedPart != NoPart)
-        invalidatePart(m_pressedPart);
     m_pressedPart = part;
-    if (m_pressedPart != NoPart)
-        invalidatePart(m_pressedPart);
-    else if (m_hoveredPart != NoPart)  // When we no longer have a pressed part, we can start drawing a hovered state on the hovered part.
-        invalidatePart(m_hoveredPart);
 }
 
 bool Scrollbar::gestureEvent(const PlatformGestureEvent& evt)
 {
     switch (evt.type()) {
     case PlatformEvent::GestureTapDown:
         // FIXME(sky): Is setting the pressed part needed since we only have overlay scrollbars?
         setPressedPart(NoPart);
         m_pressedPos = orientation() == HorizontalScrollbar ? convertFromContainingView(evt.position()).x() : convertFromContainingView(evt.position()).y();
         return true;
@@ skipping 46 matching lines @@
         m_pressedPos = orientation() == HorizontalScrollbar ? convertFromContainingView(evt.position()).x() : convertFromContainingView(evt.position()).y();
 
     // FIXME(sky): Cleanup this code now that part is always NoPart.
     ScrollbarPart part = NoPart;
     if (part != m_hoveredPart) {
         if (m_pressedPart != NoPart) {
             if (part == m_pressedPart) {
                 // The mouse is moving back over the pressed part.  We
                 // need to start up the timer action again.
                 startTimerIfNeeded(autoscrollTimerDelay());
-                invalidatePart(m_pressedPart);
             } else if (m_hoveredPart == m_pressedPart) {
                 // The mouse is leaving the pressed part.  Kill our timer
                 // if needed.
                 stopTimerIfNeeded();
-                invalidatePart(m_pressedPart);
             }
         }
 
         setHoveredPart(part);
     }
 
     return;
 }
 
 void Scrollbar::mouseEntered()
@@ skipping 55 matching lines @@
 }
 
 bool Scrollbar::shouldParticipateInHitTesting()
 {
     // Non-overlay scrollbars should always participate in hit testing.
     if (!isOverlayScrollbar())
         return true;
     return m_scrollableArea->scrollAnimator()->shouldScrollbarParticipateInHitTesting(this);
 }
 
-void Scrollbar::invalidateRect(const IntRect& rect)
-{
-    if (m_scrollableArea)
-        m_scrollableArea->invalidateScrollbar(this, rect);
-}
-
 IntRect Scrollbar::convertToContainingView(const IntRect& localRect) const
 {
     if (m_scrollableArea)
         return m_scrollableArea->convertFromScrollbarToContainingView(this, localRect);
 
     return Widget::convertToContainingView(localRect);
 }
 
 IntRect Scrollbar::convertFromContainingView(const IntRect& parentRect) const
 {
@@ skipping 28 matching lines @@
         return m_scrollableArea->scrollPosition().x() - m_scrollableArea->minimumScrollPosition().x();
 
     return m_scrollableArea->scrollPosition().y() - m_scrollableArea->minimumScrollPosition().y();
 }
 
 int Scrollbar::scrollbarThickness()
 {
     return kThumbThickness + kScrollbarMargin;
 }
 
-void Scrollbar::invalidatePart(ScrollbarPart part)
-{
-    if (part == NoPart)
-        return;
-
-    IntRect result;
-
-    IntRect beforeThumbRect, thumbRect, afterThumbRect;
-    splitTrack(trackRect(), beforeThumbRect, thumbRect, afterThumbRect);
-    if (part == BackTrackPart)
-        result = beforeThumbRect;
-    else if (part == ForwardTrackPart)
-        result = afterThumbRect;
-    else
-        result = thumbRect;
-
-    result.moveBy(-location());
-    invalidateRect(result);
-}
-
 int Scrollbar::thumbPosition()
 {
     if (!totalSize())
         return 0;
 
     int trackLen = trackLength();
     float proportion = static_cast<float>(currentPos()) / totalSize();
     return round(proportion * trackLen);
 }
 
@@ skipping 79 matching lines @@
         thumbRect.setWidth(thumbRect.width() - kScrollbarMargin);
         if (isLeftSideVerticalScrollbar())
             thumbRect.setX(thumbRect.x() + kScrollbarMargin);
     }
 
     DEFINE_STATIC_LOCAL(Color, color, (128, 128, 128, 128));
     context->fillRect(thumbRect, color);
 }
 
 } // namespace blink