Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: sky/engine/core/html/HTMLCanvasElement.h

Issue 842113005: Delete a bunch of noop paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.cpp ('k') | sky/engine/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2009, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2007 Alp Toker <alp@atoker.com> 3 * Copyright (C) 2007 Alp Toker <alp@atoker.com>
4 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 4 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 String toDataURLInternal(const String& mimeType, const double* quality, bool isSaving = false) const; 170 String toDataURLInternal(const String& mimeType, const double* quality, bool isSaving = false) const;
171 171
172 HashSet<RawPtr<CanvasObserver> > m_observers; 172 HashSet<RawPtr<CanvasObserver> > m_observers;
173 173
174 IntSize m_size; 174 IntSize m_size;
175 175
176 OwnPtr<CanvasRenderingContext> m_context; 176 OwnPtr<CanvasRenderingContext> m_context;
177 177
178 bool m_ignoreReset; 178 bool m_ignoreReset;
179 bool m_accelerationDisabled; 179 bool m_accelerationDisabled;
180 // FIXME(sky): Do we need this in sky since we don't do paint invalidation?
180 FloatRect m_dirtyRect; 181 FloatRect m_dirtyRect;
181 base::CancelableClosure m_finalizeFrameTask; 182 base::CancelableClosure m_finalizeFrameTask;
182 183
183 mutable intptr_t m_externallyAllocatedMemory; 184 mutable intptr_t m_externallyAllocatedMemory;
184 185
185 // It prevents HTMLCanvasElement::buffer() from continuously re-attempting t o allocate an imageBuffer 186 // It prevents HTMLCanvasElement::buffer() from continuously re-attempting t o allocate an imageBuffer
186 // after the first attempt failed. 187 // after the first attempt failed.
187 mutable bool m_didFailToCreateImageBuffer; 188 mutable bool m_didFailToCreateImageBuffer;
188 mutable bool m_didClearImageBuffer; 189 mutable bool m_didClearImageBuffer;
189 OwnPtr<ImageBuffer> m_imageBuffer; 190 OwnPtr<ImageBuffer> m_imageBuffer;
190 mutable OwnPtr<GraphicsContextStateSaver> m_contextStateSaver; 191 mutable OwnPtr<GraphicsContextStateSaver> m_contextStateSaver;
191 192
192 mutable RefPtr<Image> m_presentedImage; 193 mutable RefPtr<Image> m_presentedImage;
193 mutable RefPtr<Image> m_copiedImage; // FIXME: This is temporary for platfor ms that have to copy the image buffer to render (and for CSSCanvasValue). 194 mutable RefPtr<Image> m_copiedImage; // FIXME: This is temporary for platfor ms that have to copy the image buffer to render (and for CSSCanvasValue).
194 }; 195 };
195 196
196 } // namespace blink 197 } // namespace blink
197 198
198 #endif // SKY_ENGINE_CORE_HTML_HTMLCANVASELEMENT_H_ 199 #endif // SKY_ENGINE_CORE_HTML_HTMLCANVASELEMENT_H_
OLDNEW
« no previous file with comments | « sky/engine/core/frame/FrameView.cpp ('k') | sky/engine/core/html/HTMLCanvasElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698