Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: sky/engine/web/WebViewImpl.cpp

Issue 842113005: Delete a bunch of noop paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/web/WebViewImpl.h ('k') | sky/engine/web/painting/PaintAggregator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1267 matching lines...) Expand 10 before | Expand all | Expand 10 after
1278 1278
1279 void WebViewImpl::sendResizeEventAndRepaint() 1279 void WebViewImpl::sendResizeEventAndRepaint()
1280 { 1280 {
1281 // FIXME: This is wrong. The FrameView is responsible sending a resizeEvent 1281 // FIXME: This is wrong. The FrameView is responsible sending a resizeEvent
1282 // as part of layout. Layout is also responsible for sending invalidations 1282 // as part of layout. Layout is also responsible for sending invalidations
1283 // to the embedder. This method and all callers may be wrong. -- eseidel. 1283 // to the embedder. This method and all callers may be wrong. -- eseidel.
1284 if (localFrameRootTemporary()->frameView()) { 1284 if (localFrameRootTemporary()->frameView()) {
1285 // Enqueues the resize event. 1285 // Enqueues the resize event.
1286 localFrameRootTemporary()->frame()->document()->enqueueResizeEvent(); 1286 localFrameRootTemporary()->frame()->document()->enqueueResizeEvent();
1287 } 1287 }
1288
1289 WebRect damagedRect(0, 0, m_size.width, m_size.height);
1290 m_client->didInvalidateRect(damagedRect);
1291 } 1288 }
1292 1289
1293 void WebViewImpl::setCompositorDeviceScaleFactorOverride(float deviceScaleFactor ) 1290 void WebViewImpl::setCompositorDeviceScaleFactorOverride(float deviceScaleFactor )
1294 { 1291 {
1295 m_compositorDeviceScaleFactorOverride = deviceScaleFactor; 1292 m_compositorDeviceScaleFactorOverride = deviceScaleFactor;
1296 } 1293 }
1297 1294
1298 void WebViewImpl::setIsTransparent(bool isTransparent) 1295 void WebViewImpl::setIsTransparent(bool isTransparent)
1299 { 1296 {
1300 // Set any existing frames to be transparent. 1297 // Set any existing frames to be transparent.
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
1383 void WebViewImpl::setTabsToLinks(bool enable) 1380 void WebViewImpl::setTabsToLinks(bool enable)
1384 { 1381 {
1385 m_tabsToLinks = enable; 1382 m_tabsToLinks = enable;
1386 } 1383 }
1387 1384
1388 bool WebViewImpl::tabsToLinks() const 1385 bool WebViewImpl::tabsToLinks() const
1389 { 1386 {
1390 return m_tabsToLinks; 1387 return m_tabsToLinks;
1391 } 1388 }
1392 1389
1393 void WebViewImpl::suppressInvalidations(bool enable)
1394 {
1395 m_client->suppressCompositorScheduling(enable);
1396 }
1397
1398 void WebViewImpl::invalidateRect(const IntRect& rect)
1399 {
1400 m_client->didInvalidateRect(rect);
1401 }
1402
1403 void WebViewImpl::scheduleAnimation() 1390 void WebViewImpl::scheduleAnimation()
1404 { 1391 {
1405 m_client->scheduleAnimation(); 1392 m_client->scheduleAnimation();
1406 } 1393 }
1407 1394
1408 bool WebViewImpl::detectContentOnTouch(const WebPoint& position) 1395 bool WebViewImpl::detectContentOnTouch(const WebPoint& position)
1409 { 1396 {
1410 HitTestResult touchHit = hitTestResultForWindowPos(position); 1397 HitTestResult touchHit = hitTestResultForWindowPos(position);
1411 1398
1412 if (touchHit.isContentEditable()) 1399 if (touchHit.isContentEditable())
(...skipping 20 matching lines...) Expand all
1433 void WebViewImpl::setVisibilityState(WebPageVisibilityState visibilityState, 1420 void WebViewImpl::setVisibilityState(WebPageVisibilityState visibilityState,
1434 bool isInitialState) { 1421 bool isInitialState) {
1435 if (!page()) 1422 if (!page())
1436 return; 1423 return;
1437 1424
1438 ASSERT(visibilityState == WebPageVisibilityStateVisible || visibilityState = = WebPageVisibilityStateHidden); 1425 ASSERT(visibilityState == WebPageVisibilityStateVisible || visibilityState = = WebPageVisibilityStateHidden);
1439 m_page->setVisibilityState(static_cast<PageVisibilityState>(static_cast<int> (visibilityState)), isInitialState); 1426 m_page->setVisibilityState(static_cast<PageVisibilityState>(static_cast<int> (visibilityState)), isInitialState);
1440 } 1427 }
1441 1428
1442 } // namespace blink 1429 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/web/WebViewImpl.h ('k') | sky/engine/web/painting/PaintAggregator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698