Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: sky/engine/core/frame/FrameView.cpp

Issue 842113005: Delete a bunch of noop paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/html/HTMLCanvasElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 void FrameView::clear() 139 void FrameView::clear()
140 { 140 {
141 reset(); 141 reset();
142 } 142 }
143 143
144 bool FrameView::didFirstLayout() const 144 bool FrameView::didFirstLayout() const
145 { 145 {
146 return !m_firstLayout; 146 return !m_firstLayout;
147 } 147 }
148 148
149 void FrameView::invalidateRect(const IntRect& rect)
150 {
151 // FIXME(sky): Parent is always null in sky?
152 if (!parent()) {
153 if (HostWindow* window = hostWindow())
154 window->invalidateContentsAndRootView(rect);
155 }
156 }
157
158 void FrameView::setFrameRect(const IntRect& newRect) 149 void FrameView::setFrameRect(const IntRect& newRect)
159 { 150 {
160 IntRect oldRect = frameRect(); 151 IntRect oldRect = frameRect();
161 if (newRect == oldRect) 152 if (newRect == oldRect)
162 return; 153 return;
163 154
164 Widget::setFrameRect(newRect); 155 Widget::setFrameRect(newRect);
165 } 156 }
166 157
167 Page* FrameView::page() const 158 Page* FrameView::page() const
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
909 totalObjects = 0; 900 totalObjects = 0;
910 901
911 for (RenderObject* o = root; o; o = o->nextInPreOrder(root)) { 902 for (RenderObject* o = root; o; o = o->nextInPreOrder(root)) {
912 ++totalObjects; 903 ++totalObjects;
913 if (o->needsLayout()) 904 if (o->needsLayout())
914 ++needsLayoutObjects; 905 ++needsLayoutObjects;
915 } 906 }
916 } 907 }
917 908
918 } // namespace blink 909 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/frame/FrameView.h ('k') | sky/engine/core/html/HTMLCanvasElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698