Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 833513002: Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/ (Closed)

Created:
5 years, 11 months ago by penny
Modified:
5 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, grt (UTC plus 2)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/ (patchset #1 id:1 of https://codereview.chromium.org/821673004/) Reason for revert: Changes breaks internal signing infrastructure (static_assert not defined in environment somehow). Maybe after the holidays, we can revisit! Original issue's description: > replace COMPILE_ASSERT with static_assert in chrome/installer/ > > BUG=442514 > > Committed: https://crrev.com/b4aadc32a7fd6d42ac3cc9adbb20a8ee4a267572 > Cr-Commit-Position: refs/heads/master@{#309684} TBR=gab@chromium.org,mostynb@opera.com NOTREECHECKS=true NOTRY=true BUG=442514 Committed: https://crrev.com/da9d12af3c9a29fdbf41af975c5bb93fdc7b8138 Cr-Commit-Position: refs/heads/master@{#309720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M chrome/installer/mini_installer/mini_string.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/channel_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/installer/util/logging_installer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/util/util_constants.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
penny
Created Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/
5 years, 11 months ago (2014-12-29 20:30:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833513002/1
5 years, 11 months ago (2014-12-29 20:31:54 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2014-12-29 20:31:56 UTC) #4
matthewyuan
On 2014/12/29 20:31:56, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 11 months ago (2014-12-29 21:37:31 UTC) #6
gab
lgtm, CC grt: looks like we need to double check internal infrastructure support for C++11.
5 years, 11 months ago (2014-12-29 21:44:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833513002/1
5 years, 11 months ago (2014-12-29 21:49:28 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2014-12-29 21:50:21 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da9d12af3c9a29fdbf41af975c5bb93fdc7b8138 Cr-Commit-Position: refs/heads/master@{#309720}
5 years, 11 months ago (2014-12-29 21:51:06 UTC) #15
Mostyn Bramley-Moore
A temporary option might be to add a local macro for chrome/installer/ rather than for ...
5 years, 11 months ago (2014-12-29 21:55:28 UTC) #16
gab
5 years, 11 months ago (2014-12-30 14:31:26 UTC) #17
Message was sent while issue was closed.
On 2014/12/29 21:55:28, Mostyn Bramley-Moore wrote:
> A temporary option might be to add a local macro for chrome/installer/ rather
> than for all of chromium.  I can take a look after the holidays.

Yea that'd make sense IMO.

Powered by Google App Engine
This is Rietveld 408576698