chrome/installer/util/logging_installer.h - Issue 833513002: Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/logging_installer.h

Issue 833513002: Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/logging_installer.h

diff --git a/chrome/installer/util/logging_installer.h b/chrome/installer/util/logging_installer.h

index 2cafd35b4e4869df1e4db5df2f810d070f4d58db..42153ba4b83cc8e2b612d223eae08dec245fc831 100644

--- a/chrome/installer/util/logging_installer.h

+++ b/chrome/installer/util/logging_installer.h

@@ -24,9 +24,8 @@

// truncation on every update.

const int kTruncatedInstallerLogFileSize = kMaxInstallerLogFileSize / 2;

-static_assert(kTruncatedInstallerLogFileSize < kMaxInstallerLogFileSize,

- "kTruncatedInstallerLogFileSize should be less than "

- "kMaxInstallerLogFileSize");

+COMPILE_ASSERT(kTruncatedInstallerLogFileSize < kMaxInstallerLogFileSize,

+ kTruncatedInstallerLogFileSize_not_lt_kMaxInstallerLogFileSize);

enum TruncateResult {

LOGFILE_UNTOUCHED,

« no previous file with comments | « chrome/installer/util/installer_state.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »