chrome/installer/util/channel_info.cc - Issue 833513002: Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/channel_info.cc

Issue 833513002: Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/channel_info.cc

diff --git a/chrome/installer/util/channel_info.cc b/chrome/installer/util/channel_info.cc

index eecb66e9458a9db1be30bcf95a62e8538f71f02b..cdf264bad0e11810732746b1948b0259146eea89 100644

--- a/chrome/installer/util/channel_info.cc

+++ b/chrome/installer/util/channel_info.cc

@@ -58,8 +58,8 @@

NUM_MODIFIERS

};

-static_assert(NUM_MODIFIERS == arraysize(kModifiers),

- "kModifiers should have NUM_MODIFIERS elements");

+COMPILE_ASSERT(NUM_MODIFIERS == arraysize(kModifiers),

+ kModifiers_disagrees_with_ModifierIndex_comma_they_must_match_bang);

// Returns true if the modifier is found, in which case |position| holds the

// location at which the modifier was found. The number of characters in the

« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/delete_tree_work_item.cc » ('j') | no next file with comments »