chrome/installer/util/shell_util.cc - Issue 833513002: Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/shell_util.cc

Issue 833513002: Revert of replace COMPILE_ASSERT with static_assert in chrome/installer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/shell_util.cc

diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc

index f2706a1030a3d09b2a18cfc5ee79458e85496f79..22261c1a639da79e1a209d3a1d88e2d789031ecf 100644

--- a/chrome/installer/util/shell_util.cc

+++ b/chrome/installer/util/shell_util.cc

@@ -151,8 +151,7 @@

NOTREACHED();

return;

}

- static_assert(sizeof(base::MD5Digest) == 16,

- "size of MD5Digest should be 16");

+ COMPILE_ASSERT(sizeof(base::MD5Digest) == 16, size_of_MD5_not_as_expected_);

base::MD5Digest md5_digest;

std::string user_sid_ascii(base::UTF16ToASCII(user_sid));

base::MD5Sum(user_sid_ascii.c_str(), user_sid_ascii.length(), &md5_digest);

« no previous file with comments | « chrome/installer/util/logging_installer.h ('k') | chrome/installer/util/util_constants.h » ('j') | no next file with comments »