Issue 829913004: WIP: Plumbing through text selection granularity control support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 829913004: WIP: Plumbing through text selection granularity control support (Closed)

Created:
5 years, 11 months ago by mfomitchev

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@unified_text_selection_diff

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

WIP: Plumbing through text selection granularity control support BUG=NONE

Patch Set 1 #

Patch Set 2 : More plumbing #

Patch Set 3 : selection_granularity.h into a separate file. #

Patch Set 4 : Missing file. #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -24 lines)			Patch
M	content/browser/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/touch_selection_controller_aura_client_impl.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/web_contents/touch_selection_controller_aura_client_impl.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 2	3 chunks	+7 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	3 chunks	+25 lines, -2 lines	0 comments	Download
M	content/common/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/input_messages.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	content/renderer/render_frame_impl.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	content/renderer/render_frame_impl.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/touch_selection/BUILD.gn	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	ui/touch_selection/selection_granularity.h	View	1 2 3	1 chunk	+20 lines, -0 lines	0 comments	Download
M	ui/touch_selection/touch_selection_controller.h	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	ui/touch_selection/touch_selection_controller.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/touch_selection/touch_selection_controller_aura.h	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/touch_selection/touch_selection_controller_aura.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/touch_selection/ui_touch_selection.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download