content/browser/renderer_host/render_widget_host_view_android.cc - Issue 829913004: WIP: Plumbing through text selection granularity control support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 829913004: WIP: Plumbing through text selection granularity control support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unified_text_selection_diff

Patch Set: Missing file. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/browser/web_contents/touch_selection_controller_aura_client_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index a034f0bed4c061acc12c8aedc75076c88c7def84..2e4c88361254e1b2b3abed57096992f0944e6671 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -1243,9 +1243,10 @@ void RenderWidgetHostViewAndroid::MoveCaret(const gfx::PointF& position) {

}

void RenderWidgetHostViewAndroid::MoveRangeSelectionExtent(

- const gfx::PointF& extent) {

+ const gfx::PointF& extent,

+ ui::TextSelectionGranularity granularity) {

DCHECK(content_view_core_);

- content_view_core_->MoveRangeSelectionExtent(extent);

+ content_view_core_->MoveRangeSelectionExtent(extent, granularity);

}

void RenderWidgetHostViewAndroid::SelectBetweenCoordinates(