content/browser/web_contents/touch_selection_controller_aura_client_impl.cc - Issue 829913004: WIP: Plumbing through text selection granularity control support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/touch_selection_controller_aura_client_impl.cc

Issue 829913004: WIP: Plumbing through text selection granularity control support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unified_text_selection_diff

Patch Set: Missing file. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/touch_selection_controller_aura_client_impl.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/touch_selection_controller_aura_client_impl.cc

diff --git a/content/browser/web_contents/touch_selection_controller_aura_client_impl.cc b/content/browser/web_contents/touch_selection_controller_aura_client_impl.cc

index a457c10add736f166434fdcacf9590adf5d76fdc..0768aef158041b741990bb348e3710b307fa4cff 100644

--- a/content/browser/web_contents/touch_selection_controller_aura_client_impl.cc

+++ b/content/browser/web_contents/touch_selection_controller_aura_client_impl.cc

@@ -37,11 +37,13 @@ void TouchSelectionControllerAuraClientImpl::MoveCaret(

}

void TouchSelectionControllerAuraClientImpl::MoveRangeSelectionExtent(

- const gfx::PointF& extent) {

+ const gfx::PointF& extent,

+ ui::TextSelectionGranularity granularity) {

RenderViewHost* rvh = RenderViewHost::From(rwhva_->GetRenderWidgetHost());

WebContentsImpl* wc =

static_cast<WebContentsImpl*>(WebContents::FromRenderViewHost(rvh));

- wc->MoveRangeSelectionExtent(gfx::Point(extent.x(), extent.y()));

+ wc->MoveRangeSelectionExtent(gfx::Point(extent.x(), extent.y()),

+ granularity);

}

void TouchSelectionControllerAuraClientImpl::SelectBetweenCoordinates(