content/browser/renderer_host/render_widget_host_view_android.h - Issue 829913004: WIP: Plumbing through text selection granularity control support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 829913004: WIP: Plumbing through text selection granularity control support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unified_text_selection_diff

Patch Set: Missing file. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index 0ac51719ea1b346941033edeffc9585445e552c9..0721c0bbdc58bcd1551e299aa6950e696566f179 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -211,7 +211,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

virtual bool SupportsAnimation() const override;

virtual void SetNeedsAnimate() override;

virtual void MoveCaret(const gfx::PointF& position) override;

- virtual void MoveRangeSelectionExtent(const gfx::PointF& extent) override;

+ virtual void MoveRangeSelectionExtent(

+ const gfx::PointF& extent,

+ ui::TextSelectionGranularity granularity) override;

virtual void SelectBetweenCoordinates(const gfx::PointF& base,

const gfx::PointF& extent) override;

virtual void OnSelectionEvent(ui::SelectionEventType event,