content/browser/android/content_view_core_impl.cc - Issue 829913004: WIP: Plumbing through text selection granularity control support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 829913004: WIP: Plumbing through text selection granularity control support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unified_text_selection_diff

Patch Set: Missing file. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 189ac67d4a19286d009d5007891ce90cd23d473a..bf729d599147944eebbb7461a71e8f25c3dd277f 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -778,11 +778,14 @@ void ContentViewCoreImpl::RemoveLayer(scoped_refptr<cc::Layer> layer) {

root_layer_->SetIsDrawable(true);

}

-void ContentViewCoreImpl::MoveRangeSelectionExtent(const gfx::PointF& extent) {

+void ContentViewCoreImpl::MoveRangeSelectionExtent(

+ const gfx::PointF& extent,

+ ui::TextSelectionGranularity granularity) {

if (!web_contents_)

return;

- web_contents_->MoveRangeSelectionExtent(gfx::Point(extent.x(), extent.y()));

+ web_contents_->MoveRangeSelectionExtent(gfx::Point(extent.x(), extent.y()),

+ granularity);

}

void ContentViewCoreImpl::SelectBetweenCoordinates(const gfx::PointF& base,