Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan). (Closed)

Created:
5 years, 11 months ago by rmacnak
Modified:
5 years, 11 months ago
Reviewers:
vsm, terry, siva
CC:
reviews+dom_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Track some changes to reference types (mostly Blink types moving to Oilpan). BUG= R=vsm@google.com Committed: https://src.chromium.org/viewvc/blink/branches/dart/dartium?view=rev&revision=188413

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -35 lines) Patch
M Source/bindings/dart/scripts/dart_methods.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/dart/scripts/dart_types.py View 1 2 7 chunks +1 line, -11 lines 0 comments Download
M Source/bindings/dart/scripts/templates/callback_interface_h.template View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/dart/custom/DartSQLTransactionCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 11 months ago (2015-01-14 21:18:21 UTC) #2
vsm
lgtm
5 years, 11 months ago (2015-01-14 21:40:55 UTC) #3
rmacnak
5 years, 11 months ago (2015-01-14 22:09:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 188413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698