Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/bindings/dart/scripts/dart_types.py

Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan). (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/scripts/dart_types.py
diff --git a/Source/bindings/dart/scripts/dart_types.py b/Source/bindings/dart/scripts/dart_types.py
index 27f962d1cd9aed19bae35086196ad82041029502..95848e0def5a517642eb810b91275c6e63d0c9ec 100644
--- a/Source/bindings/dart/scripts/dart_types.py
+++ b/Source/bindings/dart/scripts/dart_types.py
@@ -50,11 +50,9 @@ from v8_globals import includes
################################################################################
NON_WRAPPER_TYPES = frozenset([
- 'CompareHow',
'Dictionary',
'EventHandler',
'EventListener',
- 'MediaQueryListListener',
'NodeFilter',
'SerializedScriptValue',
])
@@ -105,11 +103,10 @@ CPP_UNSIGNED_TYPES = set([
'unsigned short',
])
CPP_SPECIAL_CONVERSION_RULES = {
- 'CompareHow': 'Range::CompareHow',
'Date': 'double',
'Dictionary': 'Dictionary',
'EventHandler': 'EventListener*',
- 'MediaQueryListListener': 'RefPtrWillBeRawPtr<MediaQueryListListener>',
+ 'NodeFilter': 'RefPtrWillBeRawPtr<NodeFilter>',
'Promise': 'ScriptPromise',
'ScriptValue': 'ScriptValue',
# FIXME: Eliminate custom bindings for XPathNSResolver http://crbug.com/345529
@@ -169,8 +166,6 @@ def cpp_type(idl_type, extended_attributes=None, raw_type=False, used_as_rvalue_
if idl_type.is_typed_array_type and raw_type:
return 'RefPtr<%s>' % base_idl_type
- if idl_type.is_callback_interface:
- return 'OwnPtr<%s>' % base_idl_type
if idl_type.is_interface_type:
implemented_as_class = idl_type.implemented_as
if raw_type:
@@ -300,7 +295,6 @@ def includes_for_cpp_class(class_name, relative_dir_posix):
# TODO(terry): Will we need this group header for dart:blink?
INCLUDES_FOR_TYPE = {
'object': set(),
- 'CompareHow': set(),
'Dictionary': set(['bindings/core/v8/Dictionary.h']),
'EventHandler': set(),
'EventListener': set(),
@@ -310,7 +304,6 @@ INCLUDES_FOR_TYPE = {
'core/html/HTMLCollection.h',
'core/html/HTMLFormControlsCollection.h',
'core/html/HTMLTableRowsCollection.h']),
- 'MediaQueryListListener': set(['core/css/MediaQueryListListener.h']),
'NodeList': set(['bindings/core/dart/DartNodeList.h',
'core/dom/NameNodeList.h',
'core/dom/NodeList.h',
@@ -410,10 +403,8 @@ DART_TO_CPP_VALUE = {
'long long': 'DartUtilities::dartToLongLong(args, {index}, exception)',
'unsigned long long': 'DartUtilities::dartToUnsignedLongLong(args, {index}, exception)',
# Interface types
- 'CompareHow': 'static_cast<Range::CompareHow>(0) /* FIXME, DART_TO_CPP_VALUE[CompareHow] */',
'Dictionary': 'DartUtilities::dartToDictionary{null_check}(args, {index}, exception)',
'EventTarget': '0 /* FIXME, DART_TO_CPP_VALUE[EventTarget] */',
- 'MediaQueryListListener': 'nullptr /* FIXME, DART_TO_CPP_VALUE[MediaQueryListener] */',
'NodeFilter': 'nullptr /* FIXME, DART_TO_CPP_VALUE[NodeFilter] */',
'Promise': 'DartUtilities::dartToScriptPromise{null_check}(args, {index})',
'SerializedScriptValue': 'nullptr /* FIXME, DART_TO_CPP_VALUE[SerializedScriptValue] */',
@@ -713,7 +704,6 @@ def dart_set_return_value_union(idl_type, cpp_value, extended_attributes=None,
release: can be either False (False for all member types) or
a sequence (list or tuple) of booleans (if specified individually).
"""
-
return [
# FIXME(vsm): Why do we use 'result' instead of cpp_value as V8?
member_type.dart_set_return_value('result' + str(i),
« no previous file with comments | « Source/bindings/dart/scripts/dart_methods.py ('k') | Source/bindings/dart/scripts/templates/callback_interface_h.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698