Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp - Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp

Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan). (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp ('k') | Source/bindings/modules/dart/custom/DartSQLTransactionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp

diff --git a/Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp b/Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp

index 6ece62415b58d0578ce6c8153e098b500ca479ea..fec2e9c4a933edcf32d5d846e87e15e4bd7f344e 100644

--- a/Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp

+++ b/Source/bindings/modules/dart/custom/DartDeviceOrientationEventCustom.cpp

@@ -76,8 +76,8 @@ void initDeviceOrientationEventCallback(Dart_NativeArguments args)

goto fail;

bool absoluteProvided = true;

- RefPtr<DeviceOrientationData> orientation = DeviceOrientationData::create(alphaProvided, alpha, betaProvided, beta, gammaProvided, gamma, absoluteProvided, absolute);

- receiver->initDeviceOrientationEvent(type, bubbles, cancelable, orientation.get());

+ DeviceOrientationData* orientation = DeviceOrientationData::create(alphaProvided, alpha, betaProvided, beta, gammaProvided, gamma, absoluteProvided, absolute);

+ receiver->initDeviceOrientationEvent(type, bubbles, cancelable, orientation);

return;

}