Source/bindings/dart/scripts/dart_methods.py - Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/scripts/dart_methods.py

Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan). (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/dart/scripts/dart_methods.py

diff --git a/Source/bindings/dart/scripts/dart_methods.py b/Source/bindings/dart/scripts/dart_methods.py

index d670ed533e442daffa1b1d19c450a1c5f5b50078..29058d701d26706ee98974aa6c6e66e07c3e0a3b 100644

--- a/Source/bindings/dart/scripts/dart_methods.py

+++ b/Source/bindings/dart/scripts/dart_methods.py

@@ -173,8 +173,8 @@ def cpp_value(interface, method, number_of_arguments):

# EventTarget::removeEventListener

return '%s.get()' % argument_name

return argument.name

- if (idl_type.is_callback_interface or

- idl_type.name in ['NodeFilter', 'XPathNSResolver']):

+ if (idl_type.name in ['NodeFilter', 'NodeFilterOrNull',

+ 'XPathNSResolver', 'XPathNSResolverOrNull']):

# FIXME: remove this special case

return '%s.release()' % argument_name

return argument_name

« no previous file with comments | « no previous file | Source/bindings/dart/scripts/dart_types.py » ('j') | no next file with comments »