Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp

Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan). (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp
diff --git a/Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp b/Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp
index fa231d0131ae6f47ffa550dbadc857883066a1df..f4659e40252d0721d75af16f31c257e5b08b863c 100644
--- a/Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp
+++ b/Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp
@@ -60,7 +60,7 @@ static void readDoubleField(Dart_Handle value, const char* field, bool* canProvi
return;
}
-static RefPtr<DeviceMotionData::Acceleration> readAccelerationArgument(Dart_Handle value, Dart_Handle& es)
+static DeviceMotionData::Acceleration* readAccelerationArgument(Dart_Handle value, Dart_Handle& es)
{
if (Dart_IsNull(value))
return nullptr;
@@ -87,7 +87,7 @@ static RefPtr<DeviceMotionData::Acceleration> readAccelerationArgument(Dart_Hand
return DeviceMotionData::Acceleration::create(canProvideX, x, canProvideY, y, canProvideZ, z);
}
-static RefPtr<DeviceMotionData::RotationRate> readRotationRateArgument(Dart_Handle value, Dart_Handle& es)
+static DeviceMotionData::RotationRate* readRotationRateArgument(Dart_Handle value, Dart_Handle& es)
{
if (Dart_IsNull(value))
return nullptr;
@@ -134,17 +134,17 @@ void initDeviceMotionEventCallback(Dart_NativeArguments args)
if (exception)
goto fail;
- RefPtr<DeviceMotionData::Acceleration> acceleration =
+ DeviceMotionData::Acceleration* acceleration =
readAccelerationArgument(Dart_GetNativeArgument(args, 4), exception);
if (exception)
goto fail;
- RefPtr<DeviceMotionData::Acceleration> accelerationIncludingGravity =
+ DeviceMotionData::Acceleration* accelerationIncludingGravity =
readAccelerationArgument(Dart_GetNativeArgument(args, 5), exception);
if (exception)
goto fail;
- RefPtr<DeviceMotionData::RotationRate> rotationRate =
+ DeviceMotionData::RotationRate* rotationRate =
readRotationRateArgument(Dart_GetNativeArgument(args, 6), exception);
if (exception)
goto fail;
@@ -156,10 +156,10 @@ void initDeviceMotionEventCallback(Dart_NativeArguments args)
if (exception)
goto fail;
- RefPtr<DeviceMotionData> deviceMotionData =
+ DeviceMotionData* deviceMotionData =
DeviceMotionData::create(acceleration, accelerationIncludingGravity,
rotationRate, intervalProvided, interval);
- imp->initDeviceMotionEvent(type, bubbles, cancelable, deviceMotionData.get());
+ imp->initDeviceMotionEvent(type, bubbles, cancelable, deviceMotionData);
return;
}

Powered by Google App Engine
This is Rietveld 408576698