Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811373002: Remove GrCoordTransform::kPosition_CoordSet (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@jgm
Project:
skia
Visibility:
Public.

Description

Remove GrCoordTransform::kPosition_CoordSet Committed: https://skia.googlesource.com/skia/+/309d4d590964fbf7443c5bc892c132faa61a9abb

Patch Set 1 #

Patch Set 2 : fix warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -31 lines) Patch
M include/gpu/GrCoordTransform.h View 1 chunk +5 lines, -12 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
6 years ago (2014-12-18 13:56:10 UTC) #2
joshualitt
On 2014/12/18 13:56:10, bsalomon wrote: lgtm
6 years ago (2014-12-18 16:45:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811373002/1
6 years ago (2014-12-18 16:52:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/1237) Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1607)
6 years ago (2014-12-18 16:54:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811373002/40001
6 years ago (2014-12-18 18:09:40 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-18 18:17:50 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/309d4d590964fbf7443c5bc892c132faa61a9abb

Powered by Google App Engine
This is Rietveld 408576698