Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: include/gpu/GrCoordTransform.h

Issue 811373002: Remove GrCoordTransform::kPosition_CoordSet (Closed) Base URL: https://skia.googlesource.com/skia.git@jgm
Patch Set: fix warning Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrCoordTransform.h
diff --git a/include/gpu/GrCoordTransform.h b/include/gpu/GrCoordTransform.h
index b2632c411896879883fa863baaa1a3c0d40d0d3e..cd3b988f21abc66cf14f0aeabab5ec691833ce7e 100644
--- a/include/gpu/GrCoordTransform.h
+++ b/include/gpu/GrCoordTransform.h
@@ -22,22 +22,15 @@
*/
enum GrCoordSet {
/**
- * The user-space coordinates that map to the fragment being rendered. These coords account for
- * any change of coordinate system done on the CPU by GrContext before rendering, and also are
- * correct for draws that take explicit local coords rather than inferring them from the
- * primitive's positions (e.g. drawVertices). These are usually the coords a GrProcessor wants.
+ * The user-space coordinates that map to the fragment being rendered. This is the space in
+ * which SkShader operates. It is usually the space in which geometry passed to SkCanvas is
+ * specified (before the view matrix is applied). However, some draw calls take explicit local
+ * coords that map onto the geometry (e.g. drawVertices, drawBitmapRectToRect).
*/
kLocal_GrCoordSet,
/**
- * The actual vertex position. Note that GrContext may not draw using the original view matrix
- * specified by the caller, as it may have transformed vertices into another space. These are
- * usually not the coordinates a GrProcessor wants.
- */
- kPosition_GrCoordSet,
-
- /**
- * The position after it has been transformed by the view matrix.
+ * The device space position of the fragment being shaded.
*/
kDevice_GrCoordSet,
};
« no previous file with comments | « no previous file | src/gpu/GrClipMaskManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698