remove view matrix from context

remove view matrix from context

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5531d51ce7426bdae7563547326fcf0bf926a083

[joshualitt, 2014-12-17 14:39:51]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2014-12-17 14:39:52]

This sprawling change is really broad but shallow.  The thing to really look out
for is to double check I am using the right matrix everywhere.

[bsalomon, 2014-12-17 17:12:34]

https://codereview.chromium.org/808703006/diff/20001/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/808703006/diff/20001/include/core/SkShader.h#...
include/core/SkShader.h:388: virtual bool asFragmentProcessor(GrContext*, const
SkPaint&, const SkMatrix& viewM,
Need to update comments to reflect these changes. What is the second matrix for?
Not clear at all from this file.

https://codereview.chromium.org/808703006/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (left):

https://codereview.chromium.org/808703006/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:712: /**
w00t

https://codereview.chromium.org/808703006/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/808703006/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:451: const SkMatrix& viewMatrix,
I'm wondering whether the viewMatrix is needed here.. Is it different than
localMatrix? Need to update comment about dstRect transformed by context's
matrix.

https://codereview.chromium.org/808703006/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:486: *  @param viewMatrix   transformation matrix
ex space

https://codereview.chromium.org/808703006/diff/20001/include/gpu/GrPaint.h
File include/gpu/GrPaint.h (right):

https://codereview.chromium.org/808703006/diff/20001/include/gpu/GrPaint.h#ne...
include/gpu/GrPaint.h:197: /**
tx

https://codereview.chromium.org/808703006/diff/20001/src/effects/SkBlurMaskFi...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/808703006/diff/20001/src/effects/SkBlurMaskFi...
src/effects/SkBlurMaskFilter.cpp:867: if
(!grp->localCoordChangeInverse(viewMatrix)) {
eek... Gotta figure out if we can get rid of this next. (It's setting CCMs on
FPs :( )

https://codereview.chromium.org/808703006/diff/20001/src/gpu/GrBitmapTextCont...
File src/gpu/GrBitmapTextContext.cpp (right):

https://codereview.chromium.org/808703006/diff/20001/src/gpu/GrBitmapTextCont...
src/gpu/GrBitmapTextContext.cpp:205: if
(!fPaint.localCoordChangeInverse(viewMatrix)) {
:'(

Actually this one can probably go away easily by making the GP own the view
transformation.

https://codereview.chromium.org/808703006/diff/20001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/808703006/diff/20001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:563: if (!viewMatrix.hasPerspective()) {
gotta figure out how to not go to identity for persp.

[joshualitt, 2014-12-17 19:19:58]

https://codereview.chromium.org/808703006/diff/20001/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/808703006/diff/20001/include/core/SkShader.h#...
include/core/SkShader.h:388: virtual bool asFragmentProcessor(GrContext*, const
SkPaint&, const SkMatrix& viewM,
On 2014/12/17 17:12:33, bsalomon wrote:
> Need to update comments to reflect these changes. What is the second matrix
for?
> Not clear at all from this file.

:( I actually have no idea what the second matrix is for.  Its often called
'localMatrix' and in many cases its NULL.  Any clue what it is?

[joshualitt, 2014-12-17 19:37:34]

feedback incorporated

[bsalomon, 2014-12-17 20:35:17]

lgtm assuming we add localMatrix back with follow up CL (I was wrong... need vm
and lm).

[joshualitt, 2014-12-17 23:26:16]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-12-17 23:27:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/808703006/60001

[commit-bot: I haz the power, 2014-12-17 23:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 23:28:51]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[joshualitt, 2014-12-17 23:35:00]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-12-17 23:35:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/808703006/80001

[commit-bot: I haz the power, 2014-12-17 23:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 23:37:10]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[joshualitt, 2014-12-17 23:39:44]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-12-17 23:40:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/808703006/100001

[commit-bot: I haz the power, 2014-12-17 23:50:18]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/5531d51ce7426bdae7563547326fcf0bf926a083