remove view matrix from context

include/core/SkShader.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkShader_DEFINED
 #define SkShader_DEFINED
@@ skipping 367 matching lines @@
      *  the color the effect expects as its input color. If the SkShader wishes to emit a solid
      *  color then it should set paintColor to that color and not create an effect. Note that
      *  GrColor is always premul. The common patterns are to convert paint's SkColor to GrColor or
      *  to extract paint's alpha and replicate it to all channels in paintColor. Upon failure
      *  paintColor should not be modified. It is not recommended to specialize the effect to
      *  the paint's color as then many GPU shaders may be generated.
      *
      *  The GrContext may be used by the effect to create textures. The GPU device does not
      *  call createContext. Instead we pass the SkPaint here in case the shader needs paint info.
      */
-    virtual bool asFragmentProcessor(GrContext*, const SkPaint&, const SkMatrix*, GrColor*,
-                                     GrFragmentProcessor**) const;
+    virtual bool asFragmentProcessor(GrContext*, const SkPaint&, const SkMatrix& viewM,

[bsalomon, 2014/12/17 17:12:33]

Need to update comments to reflect these changes. What is the second matrix for?
Not clear at all from this file.

[joshualitt, 2014/12/17 19:19:58]

:( I actually have no idea what the second matrix is for.  Its often called
'localMatrix' and in many cases its NULL.  Any clue what it is?

+                                     const SkMatrix*, GrColor*, GrFragmentProcessor**) const;
 
     /**
      *  If the shader can represent its "average" luminance in a single color, return true and
      *  if color is not NULL, return that color. If it cannot, return false and ignore the color
      *  parameter.
      *
      *  Note: if this returns true, the returned color will always be opaque, as only the RGB
      *  components are used to compute luminance.
      */
     bool asLuminanceColor(SkColor*) const;
@@ skipping 96 matching lines @@
     // constructors.
     SkMatrix fLocalMatrix;
 
     // So the SkLocalMatrixShader can whack fLocalMatrix in its SkReadBuffer constructor.
     friend class SkLocalMatrixShader;
 
     typedef SkFlattenable INHERITED;
 };
 
 #endif