Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 805853002: DevTools: Make labeled checkbox a web component (Closed)

Created:
6 years ago by apavlov
Modified:
6 years ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Make labeled checkbox a web component This does not modify the .checkbox-filter-checkbox checkboxes to retain the UI. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187165

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -121 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/audits/AuditLauncherView.js View 3 chunks +8 lines, -12 lines 0 comments Download
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 chunk +9 lines, -11 lines 0 comments Download
M Source/devtools/front_end/components/breakpointsList.css View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/inspectorCommon.css View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/devtools/front_end/main/OverridesView.js View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/devtools/front_end/settings/SettingsScreen.js View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sources/AdvancedSearchView.js View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sources/BreakpointsSidebarPane.js View 6 chunks +14 lines, -31 lines 0 comments Download
M Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/FilterBar.js View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/devtools/front_end/ui/SearchableView.js View 1 chunk +3 lines, -5 lines 0 comments Download
M Source/devtools/front_end/ui/SettingsUI.js View 1 chunk +6 lines, -10 lines 0 comments Download
M Source/devtools/front_end/ui/StatusBar.js View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 2 chunks +31 lines, -0 lines 0 comments Download
A Source/devtools/front_end/ui/checkboxTextLabel.css View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/helpScreen.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
apavlov
6 years ago (2014-12-15 15:59:07 UTC) #1
pfeldman
lgtm
6 years ago (2014-12-15 16:31:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/805853002/20001
6 years ago (2014-12-15 16:42:26 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 19:02:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187165

Powered by Google App Engine
This is Rietveld 408576698