Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: Source/devtools/front_end/ui/FilterBar.js

Issue 805853002: DevTools: Make labeled checkbox a web component (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ui/FilterBar.js
diff --git a/Source/devtools/front_end/ui/FilterBar.js b/Source/devtools/front_end/ui/FilterBar.js
index dde1db957d097989934a771864a96da1a633b3e3..96bfb60a1add7f8ff8ac4e7e811e29717cf8008a 100644
--- a/Source/devtools/front_end/ui/FilterBar.js
+++ b/Source/devtools/front_end/ui/FilterBar.js
@@ -223,14 +223,13 @@ WebInspector.TextFilterUI = function(supportRegex)
if (this._supportRegex) {
this._filterElement.classList.add("supports-regex");
- this._regexCheckBox = this._filterElement.createChild("input");
- this._regexCheckBox.type = "checkbox";
+ var label = createCheckboxLabel(WebInspector.UIString("Regex"));
+ this._regexCheckBox = label.checkboxElement;
this._regexCheckBox.id = "text-filter-regex";
this._regexCheckBox.addEventListener("change", this._onInput.bind(this), false);
+ this._filterElement.appendChild(label);
- this._regexLabel = this._filterElement.createChild("label");
- this._regexLabel.htmlFor = "text-filter-regex";
- this._regexLabel.textContent = WebInspector.UIString("Regex");
+ this._regexLabel = this._filterElement.textElement;
}
}
« no previous file with comments | « Source/devtools/front_end/toolbox/ResponsiveDesignView.js ('k') | Source/devtools/front_end/ui/SearchableView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698