Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: Source/devtools/front_end/ui/SearchableView.js

Issue 805853002: DevTools: Make labeled checkbox a web component (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ui/FilterBar.js ('k') | Source/devtools/front_end/ui/SettingsUI.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/SearchableView.js
diff --git a/Source/devtools/front_end/ui/SearchableView.js b/Source/devtools/front_end/ui/SearchableView.js
index 5cf40180e68e90a272eaab0072f7a166e2b685ab..99be4d0c6022ee1d214c56a553d18e8b87edc24d 100644
--- a/Source/devtools/front_end/ui/SearchableView.js
+++ b/Source/devtools/front_end/ui/SearchableView.js
@@ -123,16 +123,14 @@ WebInspector.SearchableView = function(searchable, settingName)
// Column 4
this._replaceElement = this._firstRowElement.createChild("td").createChild("span");
- this._replaceCheckboxElement = this._replaceElement.createChild("input");
- this._replaceCheckboxElement.type = "checkbox";
+ this._replaceLabelElement = createCheckboxLabel(WebInspector.UIString("Replace"));
+ this._replaceCheckboxElement = this._replaceLabelElement.checkboxElement;
this._uniqueId = ++WebInspector.SearchableView._lastUniqueId;
var replaceCheckboxId = "search-replace-trigger" + this._uniqueId;
this._replaceCheckboxElement.id = replaceCheckboxId;
this._replaceCheckboxElement.addEventListener("change", this._updateSecondRowVisibility.bind(this), false);
- this._replaceLabelElement = this._replaceElement.createChild("label");
- this._replaceLabelElement.textContent = WebInspector.UIString("Replace");
- this._replaceLabelElement.setAttribute("for", replaceCheckboxId);
+ this._replaceElement.appendChild(this._replaceLabelElement);
// Column 5
var cancelButtonElement = this._firstRowElement.createChild("td").createChild("button", "search-action-button");
« no previous file with comments | « Source/devtools/front_end/ui/FilterBar.js ('k') | Source/devtools/front_end/ui/SettingsUI.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698