Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2208)

Unified Diff: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 805853002: DevTools: Make labeled checkbox a web component (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
index 8e717019767a09ef68ee37a1b9e1f4934be64855..b508f40664d87a1dbdc0badb85e709516f1d3e06 100644
--- a/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
@@ -233,25 +233,23 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {
element._type = type;
element.addEventListener("contextmenu", this._contextMenu.bind(this, node, type), true);
- var checkboxElement = createElement("input");
- checkboxElement.className = "checkbox-elem";
- checkboxElement.type = "checkbox";
- checkboxElement.checked = enabled;
- checkboxElement.addEventListener("click", this._checkboxClicked.bind(this, node, type), false);
- element._checkboxElement = checkboxElement;
- element.appendChild(checkboxElement);
+ var checkboxLabel = createCheckboxLabel(undefined, enabled);
+ checkboxLabel.className = "checkbox-elem";
+ checkboxLabel.checkboxElement.addEventListener("click", this._checkboxClicked.bind(this, node, type), false);
+ element._checkboxElement = checkboxLabel.checkboxElement;
+ element.appendChild(checkboxLabel);
- var labelElement = createElement("span");
- element.appendChild(labelElement);
var linkifiedNode = WebInspector.DOMPresentationUtils.linkifyNodeReference(node);
linkifiedNode.classList.add("monospace");
- labelElement.appendChild(linkifiedNode);
+
+ var textElement = checkboxLabel.createChild("span");
+ textElement.appendChild(linkifiedNode);
var description = createElement("div");
description.className = "source-text";
description.textContent = this._breakpointTypeLabels[type];
- labelElement.appendChild(description);
+ textElement.appendChild(description);
var currentElement = this.listElement.firstChild;
while (currentElement) {
« no previous file with comments | « Source/devtools/front_end/audits/AuditLauncherView.js ('k') | Source/devtools/front_end/components/breakpointsList.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698