Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2014)

Unified Diff: Source/devtools/front_end/settings/SettingsScreen.js

Issue 805853002: DevTools: Make labeled checkbox a web component (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/settings/SettingsScreen.js
diff --git a/Source/devtools/front_end/settings/SettingsScreen.js b/Source/devtools/front_end/settings/SettingsScreen.js
index 87a55770492fb1a2643714deec8e844105e1e2b2..ed1cde21d8a92eaea4beb0da1626fe8cd5d863a4 100644
--- a/Source/devtools/front_end/settings/SettingsScreen.js
+++ b/Source/devtools/front_end/settings/SettingsScreen.js
@@ -588,10 +588,9 @@ WebInspector.ExperimentsSettingsTab.prototype = {
_createExperimentCheckbox: function(experiment)
{
- var input = createElement("input");
- input.type = "checkbox";
+ var label = createCheckboxLabel(WebInspector.UIString(experiment.title), experiment.isEnabled());
+ var input = label.checkboxElement;
input.name = experiment.name;
- input.checked = experiment.isEnabled();
function listener()
{
experiment.setEnabled(input.checked);
@@ -600,9 +599,6 @@ WebInspector.ExperimentsSettingsTab.prototype = {
var p = createElement("p");
p.className = experiment.hidden && !experiment.isEnabled() ? "settings-experiment-hidden" : "";
- var label = p.createChild("label");
- label.appendChild(input);
- label.createTextChild(WebInspector.UIString(experiment.title));
p.appendChild(label);
return p;
},
« no previous file with comments | « Source/devtools/front_end/main/OverridesView.js ('k') | Source/devtools/front_end/sources/AdvancedSearchView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698