Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 794843002: Revert of Remove GP from drawstate, revision of invariant output for GP (Closed)

Created:
6 years ago by joshualitt
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@color-to-gp
Project:
skia
Visibility:
Public.

Description

Revert of Remove GP from drawstate, revision of invariant output for GP (patchset #9 id:160001 of https://codereview.chromium.org/791743003/) Reason for revert: breaks mac Original issue's description: > Remove GP from drawstate, revision of invariant output for GP > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c6bc58eded89b0c0a36b8e20e193c200f297a0da TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8c0f615fdd41b8b8048bf398791bb2138c511826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+483 lines, -595 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M gm/beziereffects.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M gm/convexpolyeffect.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 2 chunks +0 lines, -15 lines 0 comments Download
M include/gpu/GrInvariantOutput.h View 6 chunks +5 lines, -65 lines 0 comments Download
M include/gpu/GrProcessor.h View 2 chunks +15 lines, -0 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 6 chunks +12 lines, -15 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 12 chunks +48 lines, -54 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 8 chunks +19 lines, -17 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrDrawState.h View 9 chunks +53 lines, -21 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 12 chunks +72 lines, -40 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 9 chunks +7 lines, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 14 chunks +27 lines, -25 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 7 chunks +6 lines, -51 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 4 chunks +8 lines, -11 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 10 chunks +18 lines, -23 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 5 chunks +3 lines, -7 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 5 chunks +22 lines, -27 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 13 chunks +25 lines, -18 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 3 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 2 chunks +15 lines, -34 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 3 chunks +6 lines, -24 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 7 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GLProgramsTest.cpp View 3 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Remove GP from drawstate, revision of invariant output for GP
6 years ago (2014-12-10 22:11:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794843002/1
6 years ago (2014-12-10 22:11:50 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-10 22:12:28 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8c0f615fdd41b8b8048bf398791bb2138c511826

Powered by Google App Engine
This is Rietveld 408576698