src/gpu/effects/GrMatrixConvolutionEffect.h - Issue 794843002: Revert of Remove GP from drawstate, revision of invariant output for GP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrMatrixConvolutionEffect.h

Issue 794843002: Revert of Remove GP from drawstate, revision of invariant output for GP (Closed) Base URL: https://skia.googlesource.com/skia.git@color-to-gp

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/effects/GrMatrixConvolutionEffect.h

diff --git a/src/gpu/effects/GrMatrixConvolutionEffect.h b/src/gpu/effects/GrMatrixConvolutionEffect.h

index 8d6bb7cc107c74115d955942d02151beefa2d5f3..6d60609e314af8dff72644116f024c63aa3b45b0 100644

--- a/src/gpu/effects/GrMatrixConvolutionEffect.h

+++ b/src/gpu/effects/GrMatrixConvolutionEffect.h

@@ -81,7 +81,7 @@

virtual void onComputeInvariantOutput(GrInvariantOutput* inout) const SK_OVERRIDE {

// TODO: Try to do better?

- inout->mulByUnknownFourComponents();

+ inout->mulByUnknownColor();

}

SkIRect fBounds;

« no previous file with comments | « src/gpu/effects/GrDistanceFieldTextureEffect.cpp ('k') | src/gpu/effects/GrOvalEffect.cpp » ('j') | no next file with comments »