Apply the layer's image filter to the hoisted image

Apply the layer's image filter to the hoisted image

Exposing SkSurface_Gpu makes me sad and I would welcome alternatives.

This change is desireable since it greatly decreases the render target swaps.

Committed: https://skia.googlesource.com/skia/+/7b9e8a4b6af0f3df9bf20a5fdc0977bcd7c3c1ab

[robertphillips, 2014-12-10 18:46:57]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[bsalomon, 2014-12-10 18:54:20]

https://codereview.chromium.org/792923002/diff/1/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/792923002/diff/1/src/gpu/SkGpuDevice.h#newcod...
src/gpu/SkGpuDevice.h:137: friend class GrLayerHoister;
can the filter function be moved somewhere else? We could also make it public
since this class itself is private.

[robertphillips, 2014-12-10 19:16:10]

https://codereview.chromium.org/792923002/diff/1/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/792923002/diff/1/src/gpu/SkGpuDevice.h#newcod...
src/gpu/SkGpuDevice.h:137: friend class GrLayerHoister;
On 2014/12/10 18:54:20, bsalomon wrote:
> can the filter function be moved somewhere else? We could also make it public
> since this class itself is private.

Done.

[bsalomon, 2014-12-10 19:21:31]

lgtm but Mike should look, too.

https://codereview.chromium.org/792923002/diff/20001/src/gpu/GrLayerHoister.cpp
File src/gpu/GrLayerHoister.cpp (right):

https://codereview.chromium.org/792923002/diff/20001/src/gpu/GrLayerHoister.c...
src/gpu/GrLayerHoister.cpp:302: SkSurface_Gpu* gpuSurf =
reinterpret_cast<SkSurface_Gpu*>(surface.get());
Does static_cast work here? A little safer in case our hierarchy changes.

[robertphillips, 2014-12-10 19:28:03]

https://codereview.chromium.org/792923002/diff/20001/src/gpu/GrLayerHoister.cpp
File src/gpu/GrLayerHoister.cpp (right):

https://codereview.chromium.org/792923002/diff/20001/src/gpu/GrLayerHoister.c...
src/gpu/GrLayerHoister.cpp:302: SkSurface_Gpu* gpuSurf =
reinterpret_cast<SkSurface_Gpu*>(surface.get());
On 2014/12/10 19:21:31, bsalomon wrote:
> Does static_cast work here? A little safer in case our hierarchy changes.

Done.

[robertphillips, 2014-12-11 12:51:27]

Mike - ping

[reed1, 2014-12-11 15:12:48]

sounds like we should retool imagefilters to not require a device
lgtm

[robertphillips, 2014-12-11 15:14:22]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-12-11 15:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792923002/40001

[commit-bot: I haz the power, 2014-12-11 16:20:36]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7b9e8a4b6af0f3df9bf20a5fdc0977bcd7c3c1ab

[mtklein, 2014-12-13 22:22:11]

On 2014/12/11 16:20:36, I haz the power (commit-bot) wrote:
> Committed patchset #3 (id:40001) as
> https://skia.googlesource.com/skia/+/7b9e8a4b6af0f3df9bf20a5fdc0977bcd7c3c1ab

Thought you might like to know this registered as a 20-30% perf win on
desk_carsvg.skp on some of the bots: https://codereview.chromium.org/792923002

[mtklein, 2014-12-13 22:22:40]

On 2014/12/13 22:22:11, mtklein wrote:
> On 2014/12/11 16:20:36, I haz the power (commit-bot) wrote:
> > Committed patchset #3 (id:40001) as
> >
https://skia.googlesource.com/skia/+/7b9e8a4b6af0f3df9bf20a5fdc0977bcd7c3c1ab
> 
> Thought you might like to know this registered as a 20-30% perf win on
> desk_carsvg.skp on some of the bots: https://codereview.chromium.org/792923002

Err... https://skiaperf.com/cl/419