[New Multicolumn] Layout support for column-span:all.

[New Multicolumn] Layout support for column-span:all.

There are still issues with block direction margins specified on
spanners and on content adjacent to them. Will take care of that in a
follow-up CL. Similarly for overflow.

Also no support for dynamically inserting and removing spanners
yet. Another follow-up CL can be expected for that.

Added some layout tests. Removed
fast/multicol/newmulticol/direct-child-column-span-all.html .
Although it could detect crashes, it was useless rendering-wise, since
the test and the ref were identical. fast/multicol/span/sole-spanner.html
should be a satisfactory replacement.

BUG=347325
R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188619

[mstensho (USE GERRIT), 2014-12-10 13:50:48]

This is a reboot of https://codereview.chromium.org/712553003/ . It depends on
https://codereview.chromium.org/789433006/ .

No layout tests have changed here, relatively to that CL, so you can just skip
reviewing that part.

[mstensho (USE GERRIT), 2014-12-12 16:08:03]

On 2014/12/10 13:50:48, mstensho wrote:
> This is a reboot of https://codereview.chromium.org/712553003/ . It depends on
> https://codereview.chromium.org/789433006/ .
> 
> No layout tests have changed here, relatively to that CL, so you can just skip
> reviewing that part.

Now that https://codereview.chromium.org/789433006/ has landed, this CL is
readier than ever for review. :)

[mstensho (USE GERRIT), 2015-01-06 21:52:34]

ping?

[Julien - ping for review, 2015-01-19 10:05:11]

lgtm

https://codereview.chromium.org/792803002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderFlowThread.h (right):

https://codereview.chromium.org/792803002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderFlowThread.h:159: };
FYI I keep reading this patch which looks like a great refactoring on its own
(it's really a 2 minutes review)

https://codereview.chromium.org/792803002/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderMultiColumnFlowThread.cpp (right):

https://codereview.chromium.org/792803002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderMultiColumnFlowThread.cpp:164: return
m_multiColumnSetList.isEmpty() ? 0 : m_multiColumnSetList.first();
FWIW if we have no column set (m_multiColumnSetList.isEmpty()), we know that we
have to return 0 (no need for the adapter).

https://codereview.chromium.org/792803002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderMultiColumnFlowThread.cpp:204:
m_needsColumnHeightsRecalculation = columnSet->heightIsAuto();
We could avoid the branch with:

m_needsColumnHeightsRecalculation |= columnSet->heightIsAuto();

[mstensho (USE GERRIT), 2015-01-19 10:52:33]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-01-19 10:53:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/792803002/40001

[mstensho (USE GERRIT), 2015-01-19 12:02:55]

https://codereview.chromium.org/792803002/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderMultiColumnFlowThread.cpp (right):

https://codereview.chromium.org/792803002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderMultiColumnFlowThread.cpp:164: return
m_multiColumnSetList.isEmpty() ? 0 : m_multiColumnSetList.first();
On 2015/01/19 10:05:11, Julien Chaffraix - CET wrote:
> FWIW if we have no column set (m_multiColumnSetList.isEmpty()), we know that
we
> have to return 0 (no need for the adapter).

Done.

https://codereview.chromium.org/792803002/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderMultiColumnFlowThread.cpp:204:
m_needsColumnHeightsRecalculation = columnSet->heightIsAuto();
On 2015/01/19 10:05:11, Julien Chaffraix - CET wrote:
> We could avoid the branch with:
> 
> m_needsColumnHeightsRecalculation |= columnSet->heightIsAuto();

Then you'd end up calling heightIsAuto() even if
m_needsColumnHeightsRecalculation is already true, because |= is a bit-wise
operator. So I'll keep it as it is.

[commit-bot: I haz the power, 2015-01-19 12:07:33]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188619