Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h - Issue 792803002: [New Multicolumn] Layout support for column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

Issue 792803002: [New Multicolumn] Layout support for column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@347325-placeholder

Patch Set: Code review. If there are no sets, return early. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/RenderMultiColumnSet.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

diff --git a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

index d821815d4cf4b05d96068f35d100ef7c7d0b61fe..28173449687145e4c6cd709d7d4eaec633d5dfa6 100644

--- a/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

+++ b/Source/core/rendering/RenderMultiColumnSpannerPlaceholder.h

@@ -29,7 +29,10 @@ protected:

virtual void willBeRemovedFromTree() override;

virtual bool needsPreferredWidthsRecalculation() const override;

virtual void layout() override;

+ virtual void computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit logicalTop, LogicalExtentComputedValues&) const override;

virtual void invalidateTreeIfNeeded(const PaintInvalidationState&) override;

+ virtual void paint(const PaintInfo&, const LayoutPoint& paintOffset) override;

+ virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) override;

virtual const char* renderName() const override;

private:

« no previous file with comments | « Source/core/rendering/RenderMultiColumnSet.cpp ('k') | Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp » ('j') | no next file with comments »