Source/core/rendering/RenderPagedFlowThread.h - Issue 792803002: [New Multicolumn] Layout support for column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderPagedFlowThread.h

Issue 792803002: [New Multicolumn] Layout support for column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@347325-placeholder

Patch Set: Code review. If there are no sets, return early. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderPagedFlowThread.h

diff --git a/Source/core/rendering/RenderPagedFlowThread.h b/Source/core/rendering/RenderPagedFlowThread.h

index 10e6f5f9310409a16548c2337cd825ac990f8abd..0206ea2bdce4711eb8afd6331c6ecdda2de7343a 100644

--- a/Source/core/rendering/RenderPagedFlowThread.h

+++ b/Source/core/rendering/RenderPagedFlowThread.h

@@ -20,7 +20,6 @@ public:

RenderBlockFlow* pagedBlockFlow() const { return toRenderBlockFlow(parent()); }

virtual bool isRenderPagedFlowThread() const override { return true; }

- virtual bool heightIsAuto() const override { return !columnHeightAvailable(); }

virtual const char* renderName() const override;

virtual bool needsNewWidth() const override;

virtual void updateLogicalWidth() override;

« no previous file with comments | « Source/core/rendering/RenderMultiColumnSpannerPlaceholder.cpp ('k') | no next file » | no next file with comments »