Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 789343002: Revert of Create xfer processor backend. (Closed)

Created:
6 years ago by joshualitt
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xferBlendSolo
Project:
skia
Visibility:
Public.

Description

Revert of Create xfer processor backend. (patchset #6 id:100001 of https://codereview.chromium.org/764643004/) Reason for revert: CL breaks windows DM Original issue's description: > Create xfer processor backend. > > This includes: > -Having an actual XP stage at the end of the gl pipeline. > -All Blending work is handled by XP until actually setting GL blend states > -GLPrograms test to test XP > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4dffc940c430eec66d4707490eace19c9b3f7904 TBR=bsalomon@google.com,joshualitt@chromium.org,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/294738268d3a9317282224f03063eb38ad19717c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -446 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M include/gpu/GrProcessorUnitTest.h View 3 chunks +6 lines, -26 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 5 chunks +3 lines, -41 lines 0 comments Download
M include/gpu/effects/GrPorterDuffXferProcessor.h View 3 chunks +15 lines, -54 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 3 chunks +37 lines, -6 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 4 chunks +40 lines, -1 line 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 7 chunks +18 lines, -113 lines 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 5 chunks +1 line, -6 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 8 chunks +3 lines, -20 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +5 lines, -10 lines 0 comments Download
D src/gpu/gl/GrGLXferProcessor.h View 1 chunk +0 lines, -61 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 7 chunks +1 line, -23 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 6 chunks +12 lines, -53 lines 0 comments Download
M tests/GLProgramsTest.cpp View 3 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Create xfer processor backend.
6 years ago (2014-12-10 22:57:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789343002/1
6 years ago (2014-12-10 22:58:46 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-10 23:03:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/294738268d3a9317282224f03063eb38ad19717c

Powered by Google App Engine
This is Rietveld 408576698