Fix remaining WeakPtrFactory ordering problems

extensions/browser/api/declarative/rules_registry.h

Index: extensions/browser/api/declarative/rules_registry.h
diff --git a/extensions/browser/api/declarative/rules_registry.h b/extensions/browser/api/declarative/rules_registry.h
index 4fc3178050f5301f1dc825606f8440012fa63f70..76f1c0878447ebc9ca9a105fa1073ea00c09fddc 100644
--- a/extensions/browser/api/declarative/rules_registry.h
+++ b/extensions/browser/api/declarative/rules_registry.h
@@ -260,10 +260,6 @@ class RulesRegistry : public base::RefCountedThreadSafe<RulesRegistry> {
   RuleIdentifiersMap used_rule_identifiers_;
   int last_generated_rule_identifier_id_;
 
-  // The factory needs to be declared before |cache_delegate_|, so that it can
-  // produce a pointer as a construction argument for |cache_delegate_|.

[Nico, 2014/12/12 00:03:37]

please get approval from whoever wrote this comment

[dmichael (off chromium), 2014/12/12 16:57:03]

The comment was introduced here:
https://codereview.chromium.org/49693003/diff/320001/chrome/browser/extension...
became obsolete with this change:
https://codereview.chromium.org/53273002/diff/930001/chrome/browser/extension...
...but wasn't removed at that time.

I'll add fsamuel anyway, but I'm pretty confident it's safe to remove now.

-  base::WeakPtrFactory<RulesRegistry> weak_ptr_factory_;
-
   // |cache_delegate_| is owned by the registry service. If |cache_delegate_| is
   // NULL, then the storage functionality is disabled (this is used in tests).
   // This registry cannot own |cache_delegate_| because during the time after
@@ -273,6 +269,8 @@ class RulesRegistry : public base::RefCountedThreadSafe<RulesRegistry> {
   // instance.
   base::WeakPtr<RulesCacheDelegate> cache_delegate_;
 
+  base::WeakPtrFactory<RulesRegistry> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(RulesRegistry);
 };