device/usb/usb_device_handle_impl.cc - Issue 780713002: Fix remaining WeakPtrFactory ordering problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device_handle_impl.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove flag change, merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/usb/usb_device_handle_impl.cc

diff --git a/device/usb/usb_device_handle_impl.cc b/device/usb/usb_device_handle_impl.cc

index eb12542164ff8d67c28b80bbf1c0c710b8f5e311..587bbc66d8e1df0fe8d963eead818a603258ea65 100644

--- a/device/usb/usb_device_handle_impl.cc

+++ b/device/usb/usb_device_handle_impl.cc

@@ -479,8 +479,8 @@ UsbDeviceHandleImpl::UsbDeviceHandleImpl(scoped_refptr<UsbContext> context,

handle_(handle),

config_(config),

context_(context),

- weak_factory_(this),

- task_runner_(base::ThreadTaskRunnerHandle::Get()) {

+ task_runner_(base::ThreadTaskRunnerHandle::Get()),

+ weak_factory_(this) {

DCHECK(handle) << "Cannot create device with NULL handle.";

}