Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/media/remote_media_stream_impl.cc

Issue 780713002: Fix remaining WeakPtrFactory ordering problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove flag change, merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/remote_media_stream_impl.h ('k') | content/renderer/pepper/plugin_object.h » ('j') | extensions/browser/api/declarative/rules_registry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/remote_media_stream_impl.cc
diff --git a/content/renderer/media/remote_media_stream_impl.cc b/content/renderer/media/remote_media_stream_impl.cc
index 1afd7f3d0b503690ff7d0704c3a010e4ca0feea8..5365251133e042caf419ed55dc7c84e455298376 100644
--- a/content/renderer/media/remote_media_stream_impl.cc
+++ b/content/renderer/media/remote_media_stream_impl.cc
@@ -352,9 +352,9 @@ RemoteMediaStreamImpl::RemoteMediaStreamImpl(
const scoped_refptr<base::SingleThreadTaskRunner>& main_thread,
webrtc::MediaStreamInterface* webrtc_stream)
: signaling_thread_(base::ThreadTaskRunnerHandle::Get()),
- weak_factory_(this),
- observer_(new RemoteMediaStreamImpl::Observer(weak_factory_.GetWeakPtr(),
- main_thread, webrtc_stream)) {
+ weak_factory_(this) {
+ observer_ = new RemoteMediaStreamImpl::Observer(
Nico 2014/12/12 00:03:37 heh :-)
+ weak_factory_.GetWeakPtr(), main_thread, webrtc_stream);
CreateAdaptersForTracks(webrtc_stream->GetAudioTracks(),
&audio_track_observers_, main_thread);
CreateAdaptersForTracks(webrtc_stream->GetVideoTracks(),
« no previous file with comments | « content/renderer/media/remote_media_stream_impl.h ('k') | content/renderer/pepper/plugin_object.h » ('j') | extensions/browser/api/declarative/rules_registry.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698