Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 775343004: Move //mojo/shell to //shell (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move //mojo/shell to //shell //shell is unambiguous in this repository and shorter. R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b4b7af2490a55901ddb7826cff72dcf88614ace5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -9320 lines) Patch
M BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/BUILD.gn View 3 chunks +0 lines, -15 lines 0 comments Download
M mojo/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/tests/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/BUILD.gn View 1 chunk +0 lines, -422 lines 0 comments Download
D mojo/shell/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D mojo/shell/android/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/shell/android/android_handler.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/shell/android/android_handler.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D mojo/shell/android/android_handler_loader.h View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/shell/android/android_handler_loader.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/shell/android/apk/AndroidManifest.xml View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/shell/android/apk/res/layout/mojo_shell_activity.xml View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/shell/android/apk/res/values/strings.xml View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/AndroidHandler.java View 1 chunk +0 lines, -138 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/Bootstrap.java View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/FileHelper.java View 1 chunk +0 lines, -90 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoShellActivity.java View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoShellApplication.java View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/shell/android/bootstrap.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/shell/android/library_loader.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/shell/android/mojo_main.h View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/shell/android/mojo_main.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D mojo/shell/android/run_android_application_function.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/shell/app_child_process.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/shell/app_child_process.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D mojo/shell/app_child_process.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/shell/app_child_process_host.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/shell/app_child_process_host.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/shell/child_process.h View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/shell/child_process.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/shell/child_process_host.h View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/shell/child_process_host.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D mojo/shell/child_process_host_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/shell/context.h View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/shell/context.cc View 1 chunk +0 lines, -318 lines 0 comments Download
D mojo/shell/data_pipe_peek.h View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/shell/data_pipe_peek.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D mojo/shell/data_pipe_peek_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D mojo/shell/desktop/mojo_main.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D mojo/shell/domain_socket/BUILD.gn View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/shell/domain_socket/completion_callback.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/shell/domain_socket/net_error_list.h View 1 chunk +0 lines, -338 lines 0 comments Download
D mojo/shell/domain_socket/net_errors.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/shell/domain_socket/net_errors.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D mojo/shell/domain_socket/socket_descriptor.h View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/shell/domain_socket/socket_libevent.h View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/shell/domain_socket/socket_libevent.cc View 1 chunk +0 lines, -387 lines 0 comments Download
D mojo/shell/domain_socket/test_completion_callback.h View 1 chunk +0 lines, -115 lines 0 comments Download
D mojo/shell/domain_socket/test_completion_callback.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/shell/domain_socket/unix_domain_client_socket_posix.h View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/shell/domain_socket/unix_domain_client_socket_posix.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D mojo/shell/domain_socket/unix_domain_client_socket_posix_unittest.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D mojo/shell/domain_socket/unix_domain_server_socket_posix.h View 1 chunk +0 lines, -80 lines 0 comments Download
D mojo/shell/domain_socket/unix_domain_server_socket_posix.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D mojo/shell/domain_socket/unix_domain_server_socket_posix_unittest.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D mojo/shell/dynamic_application_loader.h View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/shell/dynamic_application_loader.cc View 1 chunk +0 lines, -406 lines 0 comments Download
D mojo/shell/dynamic_application_loader_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D mojo/shell/dynamic_service_runner.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/shell/dynamic_service_runner.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D mojo/shell/external_application_listener.h View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/shell/external_application_listener_posix.h View 1 chunk +0 lines, -129 lines 0 comments Download
D mojo/shell/external_application_listener_posix.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D mojo/shell/external_application_listener_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D mojo/shell/external_application_listener_win.h View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/shell/external_application_listener_win.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/shell/external_application_registrar.mojom View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/shell/external_application_registrar_connection.h View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/shell/external_application_registrar_connection.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D mojo/shell/external_application_test_main.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/shell/filename_util.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/shell/filename_util.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/shell/in_process_dynamic_service_runner.h View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/shell/in_process_dynamic_service_runner.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/shell/in_process_dynamic_service_runner_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/shell/incoming_connection_listener_posix.h View 1 chunk +0 lines, -73 lines 0 comments Download
D mojo/shell/incoming_connection_listener_posix.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D mojo/shell/incoming_connection_listener_unittest.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D mojo/shell/init.h View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/shell/init.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/shell/launcher_main.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D mojo/shell/mojo_url_resolver.h View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/shell/mojo_url_resolver.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D mojo/shell/mojo_url_resolver_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/shell/network_application_loader.h View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/shell/network_application_loader.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/shell/out_of_process_dynamic_service_runner.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/shell/out_of_process_dynamic_service_runner.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/shell/shell_test_base.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/shell/shell_test_base.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/shell/shell_test_base_unittest.cc View 1 chunk +0 lines, -308 lines 0 comments Download
D mojo/shell/shell_test_helper.h View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/shell/shell_test_helper.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/shell/shell_test_main.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/shell/switches.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/shell/switches.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/shell/task_runners.h View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/shell/task_runners.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/shell/test_child_process.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/shell/test_child_process.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/shell/ui_application_loader_android.h View 1 chunk +0 lines, -59 lines 0 comments Download
D mojo/shell/ui_application_loader_android.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M services/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/BUILD.gn View 5 chunks +29 lines, -8 lines 0 comments Download
A + shell/android/android_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/android_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/android/android_handler_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/android/android_handler_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/android/apk/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/res/layout/mojo_shell_activity.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/src/org/chromium/mojo_shell_apk/AndroidHandler.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/src/org/chromium/mojo_shell_apk/Bootstrap.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/src/org/chromium/mojo_shell_apk/FileHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/src/org/chromium/mojo_shell_apk/MojoShellActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/apk/src/org/chromium/mojo_shell_apk/MojoShellApplication.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/android/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/android/library_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + shell/android/mojo_main.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/android/mojo_main.cc View 3 chunks +6 lines, -7 lines 0 comments Download
A + shell/android/run_android_application_function.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/app_child_process.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/app_child_process.cc View 9 chunks +14 lines, -29 lines 0 comments Download
A + shell/app_child_process.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/app_child_process_host.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + shell/app_child_process_host.cc View 2 chunks +4 lines, -5 lines 0 comments Download
A + shell/child_process.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/child_process.cc View 2 chunks +7 lines, -6 lines 0 comments Download
A + shell/child_process_host.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + shell/child_process_host.cc View 4 chunks +5 lines, -8 lines 0 comments Download
A + shell/child_process_host_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + shell/context.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + shell/context.cc View 7 chunks +18 lines, -20 lines 0 comments Download
A + shell/data_pipe_peek.h View 2 chunks +16 lines, -13 lines 0 comments Download
A + shell/data_pipe_peek.cc View 9 chunks +25 lines, -22 lines 0 comments Download
A + shell/data_pipe_peek_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
A + shell/desktop/mojo_main.cc View 3 chunks +8 lines, -8 lines 0 comments Download
A + shell/domain_socket/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/domain_socket/completion_callback.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/domain_socket/net_error_list.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/domain_socket/net_errors.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + shell/domain_socket/net_errors.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + shell/domain_socket/socket_descriptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/domain_socket/socket_libevent.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + shell/domain_socket/socket_libevent.cc View 5 chunks +7 lines, -14 lines 0 comments Download
A + shell/domain_socket/test_completion_callback.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + shell/domain_socket/test_completion_callback.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/domain_socket/unix_domain_client_socket_posix.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + shell/domain_socket/unix_domain_client_socket_posix.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + shell/domain_socket/unix_domain_client_socket_posix_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + shell/domain_socket/unix_domain_server_socket_posix.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + shell/domain_socket/unix_domain_server_socket_posix.cc View 4 chunks +9 lines, -11 lines 0 comments Download
A + shell/domain_socket/unix_domain_server_socket_posix_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/dynamic_application_loader.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + shell/dynamic_application_loader.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + shell/dynamic_application_loader_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + shell/dynamic_service_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/dynamic_service_runner.cc View 6 chunks +11 lines, -16 lines 0 comments Download
A + shell/external_application_listener.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + shell/external_application_listener_posix.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + shell/external_application_listener_posix.cc View 7 chunks +13 lines, -19 lines 0 comments Download
A + shell/external_application_listener_unittest.cc View 6 chunks +24 lines, -30 lines 0 comments Download
A + shell/external_application_listener_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/external_application_listener_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/external_application_registrar.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + shell/external_application_registrar_connection.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + shell/external_application_registrar_connection.cc View 3 chunks +6 lines, -7 lines 0 comments Download
A + shell/external_application_test_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + shell/filename_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/filename_util.cc View 2 chunks +11 lines, -11 lines 0 comments Download
A + shell/in_process_dynamic_service_runner.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/in_process_dynamic_service_runner.cc View 3 chunks +6 lines, -7 lines 0 comments Download
A + shell/in_process_dynamic_service_runner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + shell/incoming_connection_listener_posix.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + shell/incoming_connection_listener_posix.cc View 3 chunks +6 lines, -7 lines 0 comments Download
A + shell/incoming_connection_listener_unittest.cc View 2 chunks +9 lines, -10 lines 0 comments Download
A + shell/init.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/init.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + shell/launcher_main.cc View 3 chunks +5 lines, -8 lines 0 comments Download
A + shell/mojo_url_resolver.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/mojo_url_resolver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + shell/mojo_url_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/network_application_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/network_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/out_of_process_dynamic_service_runner.h View 2 chunks +8 lines, -9 lines 0 comments Download
A + shell/out_of_process_dynamic_service_runner.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + shell/shell_test_base.h View 4 chunks +7 lines, -8 lines 0 comments Download
A + shell/shell_test_base.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + shell/shell_test_base_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + shell/shell_test_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/shell_test_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + shell/shell_test_main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/switches.cc View 2 chunks +12 lines, -14 lines 0 comments Download
A + shell/task_runners.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/task_runners.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/test_child_process.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + shell/test_child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
A + shell/ui_application_loader_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + shell/ui_application_loader_android.cc View 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
6 years ago (2014-12-05 01:51:56 UTC) #2
Ben Goodger (Google)
lgtm
6 years ago (2014-12-05 18:40:31 UTC) #3
jamesr
6 years ago (2014-12-05 19:21:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b4b7af2490a55901ddb7826cff72dcf88614ace5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698