Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: mojo/shell/out_of_process_dynamic_service_runner.cc

Issue 775343004: Move //mojo/shell to //shell (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/shell/out_of_process_dynamic_service_runner.h ('k') | mojo/shell/shell_test_base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "mojo/shell/out_of_process_dynamic_service_runner.h"
6
7 #include "base/bind.h"
8 #include "base/callback_helpers.h"
9 #include "base/files/file_util.h"
10 #include "base/logging.h"
11 #include "base/scoped_native_library.h"
12
13 namespace mojo {
14 namespace shell {
15
16 OutOfProcessDynamicServiceRunner::OutOfProcessDynamicServiceRunner(
17 Context* context)
18 : context_(context) {
19 }
20
21 OutOfProcessDynamicServiceRunner::~OutOfProcessDynamicServiceRunner() {
22 if (app_child_process_host_) {
23 // TODO(vtl): Race condition: If |AppChildProcessHost::DidStart()| hasn't
24 // been called yet, we shouldn't call |Join()| here. (Until |DidStart()|, we
25 // may not have a child process to wait on.) Probably we should fix
26 // |Join()|.
27 app_child_process_host_->Join();
28 }
29 }
30
31 void OutOfProcessDynamicServiceRunner::Start(
32 const base::FilePath& app_path,
33 ScopedMessagePipeHandle service_handle,
34 const base::Closure& app_completed_callback) {
35 app_path_ = app_path;
36
37 DCHECK(app_completed_callback_.is_null());
38 app_completed_callback_ = app_completed_callback;
39
40 app_child_process_host_.reset(new AppChildProcessHost(context_, this));
41 app_child_process_host_->Start();
42
43 // TODO(vtl): |app_path.AsUTF8Unsafe()| is unsafe.
44 app_child_process_host_->controller()->StartApp(
45 app_path.AsUTF8Unsafe(),
46 ScopedMessagePipeHandle(MessagePipeHandle(
47 service_handle.release().value())));
48 }
49
50 void OutOfProcessDynamicServiceRunner::AppCompleted(int32_t result) {
51 DVLOG(2) << "OutOfProcessDynamicServiceRunner::AppCompleted(" << result
52 << ")";
53
54 app_completed_callback_.Run();
55 app_completed_callback_.Reset();
56 app_child_process_host_.reset();
57 }
58
59 } // namespace shell
60 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/shell/out_of_process_dynamic_service_runner.h ('k') | mojo/shell/shell_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698