Issue 771563003: use SkClipOps where we can, legacyClip where we need to rework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 771563003: use SkClipOps where we can, legacyClip where we need to rework

Created:
6 years ago by reed2

Modified:
5 years, 10 months ago

Reviewers:
f(malita)

CC:
chromium-reviews, asanka, aandrey+blink_chromium.org, sievers+watch_chromium.org, alicet1, ozone-reviews_chromium.org, benjhayden+dwatch_chromium.org, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, msw+watch_chromium.org, paulirish+reviews_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, tfarina, yurys, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

use SkClipOps where we can, legacyClip where we need to rework BUG=skbug.com/3191 requires https://codereview.chromium.org/777643003/ to land first. Will require follow-up work to rework callers of legacyClip to stop using region-ops other than intersect or difference.

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -45 lines)			Patch
M	cc/output/software_renderer.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	cc/resources/clip_display_item.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/resources/content_layer_updater.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	cc/resources/display_list_raster_source.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/resources/picture.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/resources/picture_pile_impl.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	cc/resources/raster_source_helper.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/download/download_shelf.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/compositor/software_output_device_ozone_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/devtools/protocol/color_picker.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_graphics_2d_host.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/skia_benchmarking_extension_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/vector_canvas_unittest.cc	View	1	1 chunk	+0 lines, -22 lines	0 comments	Download
M	ui/gfx/canvas.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/ozone/platform/dri/dri_window_delegate_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/bubble/bubble_border.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

reed@chromium.org changed reviewers:
+ fmalita@chromium.org

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages