content/browser/devtools/protocol/color_picker.cc - Issue 771563003: use SkClipOps where we can, legacyClip where we need to rework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/color_picker.cc

Issue 771563003: use SkClipOps where we can, legacyClip where we need to rework Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/software_output_device_ozone_unittest.cc ('k') | content/renderer/pepper/pepper_graphics_2d_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/color_picker.cc

diff --git a/content/browser/devtools/protocol/color_picker.cc b/content/browser/devtools/protocol/color_picker.cc

index 413fcfae887b0faf3c5e3a2ba73024eef99ecd31..f47d059b92f0a08bd24da506ecad85073c2a6b2a 100644

--- a/content/browser/devtools/protocol/color_picker.cc

+++ b/content/browser/devtools/protocol/color_picker.cc

@@ -207,7 +207,7 @@ void ColorPicker::UpdateCursor() {

SkPath clip_path;

clip_path.addOval(SkRect::MakeXYWH(padding, padding, kDiameter, kDiameter));

clip_path.close();

- canvas.clipPath(clip_path, SkRegion::kIntersect_Op, true);

+ canvas.clipPath(clip_path, kIntersect_SkClipOp, true);

// Project pixels.

int pixel_count = kDiameter / kPixelSize;