Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: cc/resources/raster_source_helper.cc

Issue 771563003: use SkClipOps where we can, legacyClip where we need to rework Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture_pile_impl.cc ('k') | chrome/browser/download/download_shelf.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/raster_source_helper.cc
diff --git a/cc/resources/raster_source_helper.cc b/cc/resources/raster_source_helper.cc
index f7ef305a65a4cdc1dc7d8e4263f852d564b201ba..c564b8506a1abe8c9084a2325a7740e460166037 100644
--- a/cc/resources/raster_source_helper.cc
+++ b/cc/resources/raster_source_helper.cc
@@ -55,8 +55,7 @@ void RasterSourceHelper::PrepareForPlaybackToCanvas(
// after the content bounds grew.
canvas->save();
canvas->translate(-canvas_rect.x(), -canvas_rect.y());
- canvas->clipRect(gfx::RectToSkRect(content_rect),
- SkRegion::kDifference_Op);
+ canvas->clipRect(gfx::RectToSkRect(content_rect), kDifference_SkClipOp);
canvas->drawColor(DebugColors::MissingResizeInvalidations(),
SkXfermode::kSrc_Mode);
canvas->restore();
@@ -68,10 +67,10 @@ void RasterSourceHelper::PrepareForPlaybackToCanvas(
canvas->translate(-canvas_rect.x(), -canvas_rect.y());
gfx::Rect inflated_content_rect = content_rect;
inflated_content_rect.Inset(0, 0, -1, -1);
- canvas->clipRect(gfx::RectToSkRect(inflated_content_rect),
- SkRegion::kReplace_Op);
+ canvas->legacyClipRect(gfx::RectToSkRect(inflated_content_rect),
+ SkRegion::kReplace_Op);
canvas->clipRect(gfx::RectToSkRect(deflated_content_rect),
- SkRegion::kDifference_Op);
+ kDifference_SkClipOp);
canvas->drawColor(background_color, SkXfermode::kSrc_Mode);
canvas->restore();
}
« no previous file with comments | « cc/resources/picture_pile_impl.cc ('k') | chrome/browser/download/download_shelf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698